Retry throttled ARM Machine requests - #290
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the AKS ARM Machine client against transient ARM throttling (HTTP 429) during bootstrap by configuring the Azure SDK retry policy to use a larger, bounded retry budget and to respect ARM-provided retry-delay headers, addressing the failure described in issue #285.
Changes:
- Add a dedicated ARM Machine SDK retry configuration (30 retries, 2m per-try timeout, 5s base retry delay, 1m max backoff) and apply it to the standard ARM Machine client.
- Apply the same retry configuration to the dev-proxy ARM Machine client so proxy usage matches production retry behavior.
- Add targeted tests covering option wiring, retry on 429 for GET and create/update, honoring retry-delay headers, and stopping after the retry budget is exhausted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/aksmachine/client_armapi.go | Introduces and applies a shared ARM Machine-specific Azure SDK retry configuration. |
| pkg/aksmachine/client_armapi_test.go | Adds tests validating retry configuration and behavior for throttled ARM Machine requests. |
| pkg/aksmachine/client_armapi_proxy.go | Reuses the same ARM Machine retry configuration for the dev-proxy client. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wenxuan W (wenxuan0923)
had a problem deploying
to
e2e-testing
August 26, 2026 17:26 — with
GitHub Actions
Failure
Wenxuan W (wenxuan0923)
had a problem deploying
to
e2e-testing
August 26, 2026 17:33 — with
GitHub Actions
Failure
Wenxuan W (wenxuan0923)
temporarily deployed
to
e2e-testing
August 26, 2026 17:43 — with
GitHub Actions
Inactive
Karen Chen (karenychen)
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Fixes #285