Remove legacy system:node binding from client setup - #293
Conversation
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Checked attempts 2 and 3: both fail because the Arc identity receives HTTP 403 from |
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly removes the legacy system:node binding and preserves the required bootstrap-related RBAC, matching the stated goal with minimal risk.
Pull request overview
This PR updates the workstation-side aks-flex-config helper so that its cluster bootstrap RBAC setup no longer grants the legacy system:node role to bootstrap identities, aligning the setup script with the current, reduced permission requirements.
Changes:
- Removed the
aks-flex-node-roleClusterRoleBindingthat boundsystem:bootstrappers:aks-flex-nodetosystem:node. - Kept only the bootstrapper and CSR auto-approval
ClusterRoleBindingresources in the embedded RBAC manifest. - Added a TODO note to remove client-side RBAC setup once migration to RP-managed/CLI-extension workflows is complete.
File summaries
| File | Description |
|---|---|
| scripts/aks-flex-config | Removes the legacy system:node binding from the embedded RBAC manifest while retaining bootstrap and CSR-related bindings. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The client setup script still granted bootstrap identities the legacy
system:noderole. This compatibility binding is no longer required.RBAC manifest
aks-flex-node-roleClusterRoleBinding.Regression coverage