Skip to content

Remove legacy system:node binding from client setup - #293

Merged
hbc (bcho) merged 3 commits into
mainfrom
copilot/drop-system-node-setup-script
Sep 3, 2026
Merged

Remove legacy system:node binding from client setup#293
hbc (bcho) merged 3 commits into
mainfrom
copilot/drop-system-node-setup-script

Conversation

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The client setup script still granted bootstrap identities the legacy system:node role. This compatibility binding is no longer required.

  • RBAC manifest

    • Remove the aks-flex-node-role ClusterRoleBinding.
    • Retain bootstrap and CSR auto-approval permissions.
  • Regression coverage

    • Verify the manifest contains only the required bootstrap-related roles.

Copilot AI linked an issue Aug 28, 2026 that may be closed by this pull request
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove system:node from setup script Remove legacy system:node binding from client setup Aug 28, 2026
Copilot AI requested a review from hbc (bcho) August 28, 2026 00:31
Comment thread scripts/test_aks_flex_config.py Outdated
Comment thread scripts/aks-flex-config
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

@bcho hbc (bcho) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot check e2e failure

Copilot AI commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Copilot check e2e failure

Checked attempts 2 and 3: both fail because the Arc identity receives HTTP 403 from listBootstrapData through all 60 retries. The latest main E2E run on the base commit (d09ccdc, run 958) has the identical failure, so this predates and is unrelated to the Kubernetes RBAC change. Attempt 4 is currently running.

Copilot AI requested a review from hbc (bcho) August 29, 2026 00:13
@bcho
hbc (bcho) marked this pull request as ready for review September 3, 2026 01:42
Copilot AI lite review requested due to automatic review settings September 3, 2026 01:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change cleanly removes the legacy system:node binding and preserves the required bootstrap-related RBAC, matching the stated goal with minimal risk.

Pull request overview

This PR updates the workstation-side aks-flex-config helper so that its cluster bootstrap RBAC setup no longer grants the legacy system:node role to bootstrap identities, aligning the setup script with the current, reduced permission requirements.

Changes:

  • Removed the aks-flex-node-role ClusterRoleBinding that bound system:bootstrappers:aks-flex-node to system:node.
  • Kept only the bootstrapper and CSR auto-approval ClusterRoleBinding resources in the embedded RBAC manifest.
  • Added a TODO note to remove client-side RBAC setup once migration to RP-managed/CLI-extension workflows is complete.
File summaries
File Description
scripts/aks-flex-config Removes the legacy system:node binding from the embedded RBAC manifest while retaining bootstrap and CSR-related bindings.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bcho
hbc (bcho) merged commit 0b23236 into main Sep 3, 2026
14 of 16 checks passed
@bcho
hbc (bcho) deleted the copilot/drop-system-node-setup-script branch September 3, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drop system:node from setup script

5 participants