Skip to content

Restart HIMDS after Arc RBAC assignment - #299

Merged
Alex Huang (wenhug) merged 1 commit into
mainfrom
fix/restart-himds-after-arc-rbac
Sep 4, 2026
Merged

Restart HIMDS after Arc RBAC assignment#299
Alex Huang (wenhug) merged 1 commit into
mainfrom
fix/restart-himds-after-arc-rbac

Conversation

@bcho

@bcho hbc (bcho) commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • restart himdsd.service after assigning AKS roles to the newly created Arc machine identity
  • verify HIMDS is active before fetching AKS bootstrap data
  • avoid reusing in-memory identity state established before RBAC was granted

Context

E2E run 33900499225 connected the Arc machine successfully, but every listBootstrapData request returned HTTP 403 until the retry window expired. The Arc identity cannot receive RBAC until after onboarding creates its principal, while HIMDS starts during onboarding.

Validation

Copilot AI lite review requested due to automatic review settings September 4, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new HIMDS restart/check is currently unconditional and may introduce misleading logs and potential flakiness without a small conditional + wait loop.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Arc E2E node-join flow to avoid stale Arc identity state in HIMDS after RBAC is granted, so the subsequent listBootstrapData call can succeed reliably.

Changes:

  • Restarts himdsd.service after Arc machine RBAC assignment.
  • Verifies HIMDS is active before attempting to fetch AKS bootstrap data.
File summaries
File Description
hack/e2e/lib/node-join-arc.sh Restarts and checks HIMDS after Arc RBAC assignment, before fetching bootstrap config.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread hack/e2e/lib/node-join-arc.sh
@wenhug
Alex Huang (wenhug) merged commit 731adee into main Sep 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants