Restart HIMDS after Arc RBAC assignment - #299
Merged
Merged
Conversation
hbc (bcho)
temporarily deployed
to
e2e-testing
September 4, 2026 20:05 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new HIMDS restart/check is currently unconditional and may introduce misleading logs and potential flakiness without a small conditional + wait loop.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Arc E2E node-join flow to avoid stale Arc identity state in HIMDS after RBAC is granted, so the subsequent listBootstrapData call can succeed reliably.
Changes:
- Restarts
himdsd.serviceafter Arc machine RBAC assignment. - Verifies HIMDS is active before attempting to fetch AKS bootstrap data.
File summaries
| File | Description |
|---|---|
| hack/e2e/lib/node-join-arc.sh | Restarts and checks HIMDS after Arc RBAC assignment, before fetching bootstrap config. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hbc (bcho)
temporarily deployed
to
e2e-testing
September 4, 2026 20:48 — with
GitHub Actions
Inactive
Alex Huang (wenhug)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
himdsd.serviceafter assigning AKS roles to the newly created Arc machine identityContext
E2E run 33900499225 connected the Arc machine successfully, but every
listBootstrapDatarequest returned HTTP 403 until the retry window expired. The Arc identity cannot receive RBAC until after onboarding creates its principal, while HIMDS starts during onboarding.Validation
bash -n hack/e2e/lib/node-join-arc.shgit diff --checkE2E passed: https://github.com/Azure/AKSFlexNode/actions/runs/33914439987
listBootstrapData403Repeat E2E passed: https://github.com/Azure/AKSFlexNode/actions/runs/33918044584
listBootstrapData403 responses