fix(designer): clarify retry policy HTTP status codes UX (#9538) - #9544
Open
Krrish Mittal (takyyon) wants to merge 1 commit into
Open
fix(designer): clarify retry policy HTTP status codes UX (#9538)#9544Krrish Mittal (takyyon) wants to merge 1 commit into
Krrish Mittal (takyyon) wants to merge 1 commit into
Conversation
The retry-policy "HTTP status codes" picker did not explain how a custom list interacts with the default retryable set (408, 429, 5xx), and could not offer status codes outside its curated list. - Reword the tooltip to state that selecting codes replaces the default retryable set (only the selected codes are retried) and that leaving it empty keeps the defaults. This resolves the "instead of vs in addition to" ambiguity reported in #9538. - Add 499 (Client Closed Request) to the selectable options, a code users commonly want retried (e.g. stateless workflow timeout). The picker only accepts values from its predefined list, so this was previously unselectable. - Remove the dead `freeform` prop from SettingTagPicker: the control never committed typed-but-unmatched values, so `freeform` was misleading. - Keep 408/429/5xx in the list on purpose: under replace semantics users must be able to re-add them alongside custom codes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot stopped reviewing on behalf of
Krrish Mittal (takyyon) due to an error
August 17, 2026 15:11
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
❌ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ❌ | Add the risk:low label (body already Low, and Low is correct) |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | Credit issue reporter/PM/designer | |
| Screenshots/Videos | Add before/after tooltip + option screenshot |
Almost there — the content is solid and the declared Low risk is correct, but the PR is missing its risk:* label. Add the risk:low label to match the body, and this PR will pass.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Mon, 17 Aug 2026 15:11:53 GMT
|
Thanks for picking this up. However this implementation seems to assume that the The demo in the linked issue shows that they do not replace the standard set. They are in addition to it. Note that only 418 was specified in the array and 500 was retried as normal. It did not suppress the retry of 500 and there does not seem to be any need to explicitly include all the "normal" ones along with the additional ones. This does prove my point that the documentation is lacking on the feature though. |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Addresses the UX feedback in #9538 on the retry-policy HTTP status codes picker.
Two UX problems were reported:
This PR:
499 - Client Closed Requestto the selectable options.freeformprop fromSettingTagPicker: the control never committed typed-but-unmatched values, sofreeformwas misleading. Selection is now explicitly from the curated list.Impact of Change
SettingTagPickerno longer advertises freeform entry it did not support.Test Plan
freeform)Contributors