fix: clarify request URL publish guidance - #9563
Conversation
🔒 AI Validation PendingThis PR is from an external contributor. AI validation will be performed after manual review. Maintainers: Add the |
There was a problem hiding this comment.
Pull request overview
Updates Request and A2A Request manifest guidance to reflect publish-based URL generation.
Changes:
- Replaces “after save” with publish terminology across four descriptions.
- Covers base and Consumption A2A manifests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
base/manifests/request.ts |
Updates HTTP URL and method guidance. |
base/manifests/a2arequest.ts |
Updates Agent URL guidance. |
consumption/manifests/a2arequest.ts |
Updates Consumption Agent URL guidance. |
Suppressed comments (1)
libs/logic-apps-shared/src/designer-client-services/lib/base/manifests/request.ts:30
- “After publish” is grammatically incomplete because
publishis a verb, unlike the nounsaveit replaces. Use a user-directed sentence so this customer-facing guidance remains clear.
description: 'URL will be generated after publish',
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| type: 'string', | ||
| title: 'Agent URL', | ||
| description: 'URL will be generated after save', | ||
| description: 'URL will be generated after publish', |
There was a problem hiding this comment.
Addressed in f2216de. The copy now uses the user-directed sentence: Publish the workflow to generate the URL.
| type: 'string', | ||
| title: 'HTTP URL', | ||
| description: 'URL will be generated after save', | ||
| description: 'URL will be generated after publish', |
There was a problem hiding this comment.
Addressed in f2216de. The copy now uses the user-directed sentence: Publish the workflow to generate the URL.
| type: 'string', | ||
| title: 'Agent URL', | ||
| description: 'URL will be generated after save', | ||
| description: 'URL will be generated after publish', |
There was a problem hiding this comment.
Addressed in f2216de. The copy now uses the user-directed sentence: Publish the workflow to generate the URL.
Commit Type
Risk Level
What & Why
Closes #8559.
Request and A2A Request URLs are generated after a workflow is published, so the current "after save" descriptions give users the wrong lifecycle step. All four affected descriptions now tell users to publish the workflow to generate the URL.
Impact of Change
Test Plan
pnpm --filter @microsoft/logic-apps-shared build:libpnpm --filter @microsoft/logic-apps-shared test:lib(52 files, 966 tests)Contributors
Mia Miao (@miachillgood)
Screenshots/Videos
Not applicable; this is a text-only correction.