fix: distinguish run with payload tooltip - #9564
Conversation
🔒 AI Validation PendingThis PR is from an external contributor. AI validation will be performed after manual review. Maintainers: Add the |
There was a problem hiding this comment.
Pull request overview
Distinguishes the split Run button’s payload action through dedicated tooltip and accessibility text.
Changes:
- Dynamically selects the tooltip based on the active split-button action.
- Adds payload-action labeling and regression coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
FloatingRunButton/index.tsx |
Adds payload-specific tooltip behavior. |
floatingRunButton.spec.tsx |
Tests payload-action labeling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| it('should identify the payload action with a distinct tooltip', () => { | ||
| (LogicAppsShared.canRunBeInvokedWithPayload as Mock).mockReturnValue(true); | ||
|
|
||
| renderWithProviders(defaultProps); | ||
|
|
||
| const payloadButton = screen.getByRole('button', { name: 'Run with payload' }); | ||
| expect(payloadButton).toHaveAttribute('title', 'Run with payload'); |
There was a problem hiding this comment.
Addressed in e7d91ef. The regression test now focuses the payload action and asserts the rendered Fluent tooltip content.
| menuButton={{ | ||
| icon: runIsLoading && runHasPayload ? <Spinner size="tiny" /> : <RunWithPayloadIcon />, | ||
| 'aria-label': strings.RUN_PAYLOAD_TOOLTIP, | ||
| title: strings.RUN_PAYLOAD_TOOLTIP, |
There was a problem hiding this comment.
Addressed in e7d91ef. Removed the native title attribute and kept the Fluent tooltip plus accessible label.
Commit Type
Risk Level
What & Why
Closes #8623.
The split Run button currently applies the same generic workflow tooltip to both actions. The payload action now exposes the existing "Run with payload" string as its tooltip and accessible label, while the primary action keeps the existing run tooltip.
Impact of Change
Test Plan
vitest run src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx(33 tests)pnpm --filter @microsoft/logic-apps-designer-v2 build:libContributors
Mia Miao (@miachillgood)
Screenshots/Videos
Not applicable; the change affects tooltip copy and accessibility metadata.