fix: unify connection condition diagnostics - #9677
Closed
Hui Miao (huimiu) wants to merge 3 commits into
Closed
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 18 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
Contributor
azure.ai.projects PR buildNote This is an unsigned development build. Install it only if you trust this PR. Install the extension: azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9677/azure-ai-projects.zip"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azure.ai.connectionservices only.Why this is needed and why this approach was chosen
Unified
azure.yamlmoves connection configuration out ofagent.manifest.yaml, but next-step guidance and Doctor previously relied on manifest discovery. That could hide configured connections or suggest the wrong next action. This change collects connections consistently across standalone services and supported legacy sources, uses the same project-environment condition semantics for provisioning and diagnostics, and preserves established source precedence: standalone service, then bundled agent configuration, then legacy manifest.Condition compatibility and scope boundaries
Connection payloads may remain in local
$reffiles, while a service condition determines whether the connection participates in provisioning and diagnostics. Connection payload variables continue to use their existing service-environment behavior; condition variables use the project environment.Legacy
agent.manifest.yamldiscovery remains intentionally best-effort. Missing, unreadable, or malformed legacy manifests do not become connection-specific Doctor failures in this PR because that would alter an established compatibility contract and make connection handling stricter than model and toolbox discovery. Any strict validation should be a separate, cross-resource change.Follow-up before marking ready for review
conditionis declared at the rootazure.yamlservice entry, rather than only through a service$ref, so core scheduling, provisioning, next-step, and Doctor cannot derive different enabled sets.pkg/project.ServiceConfig.IsEnabled.Validation
go test ./internal/cmd/nextstepgo test ./internal/cmd/doctorgit diff --check