Skip to content

fix: unify connection condition diagnostics - #9677

Closed
Hui Miao (huimiu) wants to merge 3 commits into
mainfrom
hui/connection-diagnostics-migration
Closed

fix: unify connection condition diagnostics#9677
Hui Miao (huimiu) wants to merge 3 commits into
mainfrom
hui/connection-diagnostics-migration

Conversation

@huimiu

Copy link
Copy Markdown
Member

Summary

  • Make Foundry connection provisioning honor enabled azure.ai.connection services only.
  • Diagnose standalone unified connection services alongside bundled and legacy sources.
  • Record pending provisioning after init writes connection services.
  • Surface active connection configuration and condition errors in Doctor instead of skipping them.

Why this is needed and why this approach was chosen

Unified azure.yaml moves connection configuration out of agent.manifest.yaml, but next-step guidance and Doctor previously relied on manifest discovery. That could hide configured connections or suggest the wrong next action. This change collects connections consistently across standalone services and supported legacy sources, uses the same project-environment condition semantics for provisioning and diagnostics, and preserves established source precedence: standalone service, then bundled agent configuration, then legacy manifest.

Condition compatibility and scope boundaries

Connection payloads may remain in local $ref files, while a service condition determines whether the connection participates in provisioning and diagnostics. Connection payload variables continue to use their existing service-environment behavior; condition variables use the project environment.

Legacy agent.manifest.yaml discovery remains intentionally best-effort. Missing, unreadable, or malformed legacy manifests do not become connection-specific Doctor failures in this PR because that would alter an established compatibility contract and make connection handling stricter than model and toolbox discovery. Any strict validation should be a separate, cross-resource change.

Follow-up before marking ready for review

  • Enforce that service condition is declared at the root azure.yaml service entry, rather than only through a service $ref, so core scheduling, provisioning, next-step, and Doctor cannot derive different enabled sets.
  • Restore exact core semantics for whitespace-only conditions: they are disabled, matching pkg/project.ServiceConfig.IsEnabled.

Validation

  • go test ./internal/cmd/nextstep
  • go test ./internal/cmd/doctor
  • git diff --check

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
18 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added ext-agents azure.ai.agents extension ext-projects azure.ai.projects extension labels Aug 21, 2026
@huimiu

Copy link
Copy Markdown
Member Author

Superseded by independent draft PRs #9678, #9679, and #9680.

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.projects PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/9677/azure-ai-projects.zip"
  • Version: 1.0.0-beta.6.pr.9677.6729142
  • Merge commit: 4559d70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-agents azure.ai.agents extension ext-projects azure.ai.projects extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant