Support fractional totalGiB in kperf data ingest - #1311
Merged
Conversation
Drop the -first/-retry name suffix so each batch uses a stable set name "<name>-b<batch>", making object names predictable for kperf load profiles to target by prefix. Replace the rename-based retry (which left partial objects from the failed attempt as orphans) with a bounded retry loop that deletes the partial batch before re-creating, so each batch ends up with exactly COUNT objects and accurate progress accounting.
Compute object count with awk instead of shell integer arithmetic so values like 0.5 GiB work; bash $(( )) rejects decimals.
xinWeiWei24
requested review from
Liyu Ma (liyu-ma),
Vittoria (vittoriasalim) and
Lei Yao (wonderyl)
as code owners
September 4, 2026 02:09
|
For reviewers only: reply |
Lei Yao (wonderyl)
approved these changes
Sep 4, 2026
xinWeiWei24
force-pushed
the
xinwei/configmap_v2
branch
from
September 4, 2026 03:29
dbbe3b2 to
38f7338
Compare
Lei Yao (wonderyl)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute object count with awk instead of shell integer arithmetic so values like 0.5 GiB work; bash $(( )) rejects decimals.