Skip to content

ci: point the CI workflow at BHoM/CI_Toolkit - #416

Merged
sakanni merged 1 commit into
developfrom
CI_Toolkit_Proxy-#13-RefreshCIWorkflow
Aug 18, 2026
Merged

ci: point the CI workflow at BHoM/CI_Toolkit#416
sakanni merged 1 commit into
developfrom
CI_Toolkit_Proxy-#13-RefreshCIWorkflow

Conversation

@sakanni

@sakanni sakanni commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

CI_Toolkit moved from BuroHappoldEngineeringAdmin to BHoM. The old path redirects, so this removes a dependency on the redirect rather than fixing a break.

Also picks up two pattern corrections made since this file was copied: dataset compliance now uses a case-insensitive unanchored pathspec, and project compliance matches AssemblyInfo.cs at any depth instead of only at the repo root. Neither changes which files are selected in this repo today.

Still non-blocking. Tracked in CI_Toolkit_Proxy#13.
Ready for review. This carried a temporary commit touching a comment in AdapterId.cs, because a workflow-only change matches no check's file patterns and every job would otherwise self-skip. That commit has been removed, so the diff is the workflow file alone and the current run is green.

There is a failed run earlier in this PR's history and it is worth explaining, because it is not caused by this change. With the source touch present, ci-versioning executed for the first time on this repo and reported 1,056 findings. None of them are this repository's types. It resolved 0 subject assemblies, fell back to attributing the whole dependency closure, and reported defects belonging to 22 other repositories, ETABS, GSA, CFD and others among them.

That is a known limitation in the versioning check rather than anything about this repo or this diff, and it is being tracked separately. It stayed invisible here because ci-versioning had never actually run on this repository: previous pull requests changed no files it watches, so it skipped and reported success without examining anything.

Nothing in this pull request changes that behaviour either way. Merging it is safe.

@sakanni
sakanni force-pushed the CI_Toolkit_Proxy-#13-RefreshCIWorkflow branch from 9e30f4f to f4e779b Compare August 14, 2026 22:13

@peterjamesnugent peterjamesnugent left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes just repointing the path to BHoM/CI_Toolkit as evidenced by the checks passing,

@sakanni sakanni added the type:compliance Non-conforming to code guidelines label Aug 17, 2026
@bhombot-ci

bhombot-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

@sakanni just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @sakanni on Socket_Toolkit

@sakanni
sakanni merged commit 1a44727 into develop Aug 18, 2026
18 checks passed
@sakanni
sakanni deleted the CI_Toolkit_Proxy-#13-RefreshCIWorkflow branch August 18, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants