Skip to content

feat: add values schema #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izturn merged 1 commit into from
Jul 16, 2026
Merged

feat: add values schema #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions manifests/kcover/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"$schema": "https://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"agent": {
"type": "object",
"properties": {
"flavor": {
"type": "string",
"enum": [
"base",
"metax"
],
"default": "base"
}
}
}
}
Comment on lines +4 to +18

@gemini-code-assist gemini-code-assist Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current schema only validates the agent.flavor property. To make the schema validation more robust and prevent configuration errors, it is highly recommended to expand the schema to cover other critical properties defined in values.yaml, such as global.imageRegistry and controller.replicas (which should be a positive integer).

  "properties": {
    "global": {
      "type": "object",
      "properties": {
        "imageRegistry": {
          "type": "string"
        }
      }
    },
    "agent": {
      "type": "object",
      "properties": {
        "flavor": {
          "type": "string",
          "enum": [
            "base",
            "metax"
          ],
          "default": "base"
        }
      }
    },
    "controller": {
      "type": "object",
      "properties": {
        "replicas": {
          "type": "integer",
          "minimum": 1
        }
      }
    }
  }

}