Update Babel packages and enhance VtmDiceRoller features - #44
Merged
Conversation
… in VtmDiceRoller
…es and update disclaimer
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ks and update dice roll logic
Owner
Author
|
Implement significant refactors and enhancements to the Vampire: The Masquerade (V5) dice roller utility. The main improvements include a complete rewrite of the dice-rolling logic to accurately represent V5 rules and a new alert to warn about possible mistakes when rolling dice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant upgrade to the Vampire: The Masquerade (VTM) dice roller utility. The main improvements include a new visual dice rolling experience, stricter validation and user feedback, and a clearer, more user-friendly interface. Additionally, a utility function for dice rolling is now shared and the codebase has been refactored for maintainability. There are also minor dependency updates.
VTM Dice Roller UI and Functionality Enhancements:
vtm-dice-roller.tsx, dice image imports).vtm-alert.tsx, used invtm-dice-roller.tsx).vtm-dice-roller.tsx) [1] [2].Code Structure and Utilities:
rollDieutility function (dice-roller.utils.ts), and updated the dice roller to use this utility [1] [2].Documentation and Accessibility:
vtm-dice-roller.tsx).Dependency Updates:
pnpm-lock.yamlfor improved stability and compatibility [1] [2] [3] [4] [5] [6] [7] [8].These changes together provide a more interactive, visually engaging, and robust dice rolling tool for Vampire: The Masquerade players.