Add dice roller features and UI components with refactoring - #45
Merged
Conversation
…mplement willpower reroll functionality
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a willpower reroll feature to the Vampire: The Masquerade dice roller, improves the dice display and selection UX, and introduces new utility components and hooks for future extensibility.
VTM Dice Roller Enhancements
UI Components and Utilities
Portalcomponent using Radix UI'sSlotandReactDOM.createPortalfor rendering content outside the DOM hierarchy, with support for custom containers.useAsRefhook to keep a ref in sync with the latest prop value, leveraging an isomorphic layout effect for consistency across render environments.These changes collectively improve the dice roller's interactivity, user experience, and code maintainability.