Migrate components to @base-ui/react and enhance UI consistency - #47
Merged
Conversation
- Updated Separator component to use @base-ui/react/separator. - Refactored Sheet component to utilize @base-ui/react/dialog and adjusted related subcomponents. - Transitioned Sidebar component to use new hooks and removed unnecessary fetcher logic. - Updated Slider component to use @base-ui/react/slider and simplified its structure. - Refactored Switch component to utilize @base-ui/react/switch. - Migrated Tabs component to @base-ui/react/tabs and adjusted related subcomponents. - Updated Toggle and ToggleGroup components to use @base-ui/react/toggle and @base-ui/react/toggle-group. - Refactored Tooltip component to use @base-ui/react/tooltip and adjusted its content structure.
…ion from radix-ui
…e TextToSpeech voice selection
…and trimming slug output
…ad button accessibility
…ngs for Tailwind CSS
… NavMain component
Barata-Ribeiro
added
bug
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactoring efforts across the codebase, primarily focusing on standardizing component APIs, enhancing type safety, and improving UI consistency. The most significant changes include replacing the
asChildprop with a newrenderprop for several UI components, updating the navigation logic for better state management, and refining styling and placeholder logic in calculator components.Component API Refactoring:
asChildprop with a newrenderprop for components such asDropdownMenuTrigger,SidebarMenuButton,PopoverTrigger,CollapsibleTrigger,SidebarMenuSubButton, and related menu items, ensuring a more explicit and type-safe way to pass custom render elements. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Navigation and State Management:
NavMain) to use local state (openGroups) for managing the open/closed state of navigation groups, improving responsiveness and reliability of the sidebar navigation. [1] [2]Styling and UI Consistency:
.vscode/settings.jsonto enhance class detection and support for various class attribute patterns and libraries (e.g.,clsx,cva,twMerge).cnutility.Calculator Components Improvements:
Math.randomwithmathjs'srandomandfloorfor placeholder generation, and updated select and popover components for better accessibility and UI alignment. [1] [2] [3] [4] [5] [6] [7]Dependency Updates:
useEffectanduseStatein navigation components to support the new state management logic.These changes collectively improve code maintainability, type safety, and the user experience across the application.