Enhance UI with NumberField component and improve dice roller inputs - #49
Merged
Merged
Conversation
…ut in VtmDiceRoller
…nt for improved UX
…ent for enhanced user interaction
…zable label styling
…nput to enhance user experience
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, accessible, and stylable
NumberFieldcomponent and refactors both the generic and VTM dice roller utilities to use it instead of standard number inputs. This results in improved UI consistency, better accessibility, and enhanced user interaction (including increment/decrement buttons and scrub support) for numeric fields. It also cleans up imports and updates component registry configuration.Component Additions and Refactors:
NumberFieldcomponent with increment/decrement buttons, scrub area, and improved accessibility and styling. (app/components/reui/number-field.tsx)generic-dice-roller.tsx) to useNumberFieldfor the modifier input, replacing the previousInputGroupand standard number input. (app/components/pages/utilities/dice-roller/generic-dice-roller.tsx) [1] [2] [3]vtm-dice-roller.tsx) to useNumberFieldfor regular dice, hunger dice, and difficulty fields, replacing standard number inputs. (app/components/pages/utilities/dice-roller/vtm-dice-roller.tsx) [1] [2] [3] [4]Configuration and Cleanup:
components.jsonto register the new@reuicomponent registry and moved menu color/accent settings for clarity. (components.json)app/components/pages/utilities/dice-roller/vtm-dice-roller.tsx)These changes modernize numeric input handling across the dice roller utilities, improving both developer and user experience.