Improve accessibility in NumberField and update README features - #50
Merged
Conversation
…adcn, @types/node, and vite versions
…and clarify light/dark theme switching
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase, focusing on UI/UX enhancements for the dice roller utility, accessibility improvements, and dependency upgrades for better performance and compatibility.
UI/UX Improvements (Dice Roller Utility)
GenericDiceRollerto use the newInputGroupand improved focus/validation styles. Also addedsmallStepandlargeStepsupport for easier value adjustments. [1] [2]InfoIconand popover help from the modifier input for a cleaner interface. [1] [2]Accessibility Improvements
aria-hiddenattributes to icon components innumber-field.tsxto improve accessibility for screen readers. [1] [2] [3]Component API Improvements
labelClassNameinNumberFieldScrubAreato accept aClassValuetype for improved flexibility.Dependency Upgrades
lucide-react(1.28.0 → 1.30.0),react-dropzone,react-hook-form,shadcn,vite,@types/node, and others for improved features and bug fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Documentation Updates
useThemehook, and that PWA features use Serwist instead of workbox.These changes collectively improve the user experience, accessibility, and maintainability of the project.