Skip to content

Fix UTF-8 XML scanning in spreadsheet parser - #35

Merged
naaiyy merged 1 commit into
mainfrom
fix/spreadsheet-utf8-xml-scanning
Aug 27, 2026
Merged

Fix UTF-8 XML scanning in spreadsheet parser#35
naaiyy merged 1 commit into
mainfrom
fix/spreadsheet-utf8-xml-scanning

Conversation

@naaiyy

@naaiyy naaiyy commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • normalize XML scan offsets to UTF-8 character boundaries
  • advance custom number-format scanning from the matched tag
  • add regression coverage for non-ASCII number formats

The fix prevents a Rust start-byte-index-not-a-char-boundary panic on real workbooks containing currency formats such as €.

Verification

  • cargo test --manifest-path spreadsheet-view/Cargo.toml
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • pnpm run build:viewers
  • pnpm run typecheck:viewers
  • pnpm run test:viewers
  • pnpm run closure:viewer
  • pnpm run budget:viewers
  • exact production workbook opens through rebuilt Wasm

@naaiyy
naaiyy marked this pull request as ready for review August 27, 2026 00:30
@naaiyy
naaiyy merged commit 3939618 into main Aug 27, 2026
5 checks passed
@naaiyy
naaiyy deleted the fix/spreadsheet-utf8-xml-scanning branch August 27, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant