add firmware 1594EMS1.113 for Prestige 16 Studio A13VE - #797
Open
vicajilau wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #77
Adds EC firmware version
1594EMS1.113toALLOWED_FW_G2_1.This is the same laptop model already supported via
1594EMS1.109(#77 / #78), just a newer EC revision.
CONF_G2_1is reused unchanged.Device
For reference, the existing
.109entry was submitted with BIOSE1594IMS.111 in #77.
Verification
Tested by loading the module with
firmware=1594EMS1.109and checkingthat every attribute returned correct data before writing anything.
Reads, all consistent with the actual state of the machine:
fw_version→1594EMS1.113, read correctly from the ECfw_release_date→2024-10-07, matches the DMIbios_date(10/07/2024)charge_control_end_threshold/start_threshold→ 100 / 90 (factory default)cpu/realtime_temperature53 °C,gpu/realtime_temperature46 °C — plausible at idlecpu/realtime_fan_speed50,gpu/realtime_fan_speed60webcamon,webcam_blockoff — matches the built-in camerashift_modecomfort,fan_modeauto,cooler_boostoff,super_batteryoff— all valid values from the corresponding
available_*listsfn_keyright,win_keyleftNo out-of-range or garbage values, which indicates the register map of
the
.109profile is unchanged on.113.Writes, after the reads checked out:
charge_control_end_thresholdset to 80 → accepted,start_thresholdadjusted to 70 automatically
options msi-ec firmware=1594EMS1.109in/etc/modprobe.d/ChargeThresholdSupported: trueand GNOME Settingsexposes the charge limit control
EC memory dump
Taken with
ec_sys(read-only) while the charge limit was set to 80%,so
0xd7readsd0(0x80 | 80) rather than the factory80.Compared against the
.109dump in #77, the layout is identical:0xa0holds the firmware string in ASCII (1594EMS1.113+1007202413:20:06), matching thefw_release_datereported by the driver0xd7is the charge control register, asCONF_G2_1expects