canonical_senf_pln - #4
Open
danielbirhanu wants to merge 14 commits into
Open
Conversation
BekLG
requested changes
Jul 29, 2026
BekLG
left a comment
Owner
There was a problem hiding this comment.
@danielbirhanu, I reviewed this in depth and also ran the 25-case stress benchmark locally. Here are the main implementation issues I found in the SENF path:
- The SENF layer is too permissive about what it enriches.
parsers/canonical_senf_pln_parser.pysends all base-parser statements into SENF processing.core/senf.pythen extracts entities from very broad atom shapes, including atoms that are not clearly relevant.- This appears to let noisy base output propagate into identity edges, TransWeave alignments, and bridge atoms instead of being filtered out first.
- Predicate-family bridging is still incomplete.
core/pln_bridge.pycurrently emitsSimilarityLink/ContextLink, but that does not solve cases where the generated statements and the final query use different predicate heads.- In practice, there are cases where SENF has semantically relevant atoms available, but the final query still asks for an unsupported predicate family.
- Query execution can drift away from the strongest supported symbolic form.
canonical_senf_plndelegates query parsing to the canonical parser and enriches afterward.- Because query replanning happens against the available statements/context, the executed query can end up stricter or differently abstracted than the atoms SENF actually produced, which leaves the query looking aligned but still unprovable.
- TransWeave is currently too broad to act as a reliable semantic filter.
core/transweave.pybuilds weaves from a wide cross-product of extracted entities and uses a very lightweight matching rule.- Combined with permissive entity extraction, this makes the alignment step vulnerable to noisy or accidental matches.
- The identity/exemplar scoring is still too shallow for the amount of graph expansion it introduces.
core/exemplar_registry.pyandcore/identity_graph.pyrely on a very small hardcoded exemplar set plus lightweight kind/exemplar checks.- That may be fine for a prototype, but in the current form it does not seem strong enough to justify broad identity expansion over all extracted entities.
Suggested direction:
- narrow the atoms/entities that are allowed into SENF enrichment
- add explicit predicate bridging, not only entity similarity bridging
- constrain TransWeave to query-relevant or kind-compatible structures
- keep the final executed query close to predicates that were actually generated and supported
Overall, this looks promising as an experimental direction, but these SENF-side issues should be tightened before it can be relied on as a stronger reasoning path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Identity-Aware Semantic Parsing to improve semantic alignment and eliminate brittle symbol mismatches.
Changes
chess_gamevs.football_game).SimilarityLinkatoms for more robust, confidence-based reasoning.Testing