feat(statics): add TestingLinearTokenOnboarding (eth:tlto) token#9322
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Draft
feat(statics): add TestingLinearTokenOnboarding (eth:tlto) token#9322bitgo-ai-agent-dev[bot] wants to merge 1 commit into
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
Add TestingLinearTokenOnboarding test token on eth to @bitgo/statics. This is a test-environment-only placeholder token used to validate the Linear-ticket execution route of the token-onboarding pipeline. Changes: - base.ts: add 'eth:tlto' to UnderlyingAsset enum (alphabetical, before 'eth:tlton') - erc20Coins.ts: add terc20() factory call for on-chain token (UUID 97753436-903b-4131-82b2-6deea76a5e17, 6 decimals, contract 0x1234567890abcdef1234567890abcdef12345678) - ofcErc20Coins.ts: add ofcerc20() factory call for OFC token (UUID d38204a7-b670-414e-9f58-e2df4798070c) Ticket: SCAAS-10476 Session-Id: 9ba79c7d-bf8e-4752-a1af-56377ef25bd2 Task-Id: c094e07d-948d-41b0-95b6-0409e5eb6767
Contributor
Author
|
@claude please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
'eth:tlto'to theUnderlyingAssetenum inbase.ts(alphabetical, before'eth:tlton')terc20()factory call inerc20Coins.tsfor the on-chain token (UUID97753436-903b-4131-82b2-6deea76a5e17, 6 decimals, contract0x1234567890abcdef1234567890abcdef12345678)ofcerc20()factory call inofcErc20Coins.tsfor the OFC token (UUIDd38204a7-b670-414e-9f58-e2df4798070c)Why
indexer-token-addand subsequent onboarding steps under the parent epic SCAAS-10475.Decision log
Placement of
terc20()inerc20Coins.ts: Inserted after the lastterc20()call using the default eth testnet (kovan), before the holesky/hoodi-specific blocks. Options: (A) insert at the very end of the file beforehteth:entries, (B) insert after the last kovan-defaultterc20. Chose B — keeps testnet entries grouped by default network and avoids mixing eth and hteth blocks.Placement of
ofcerc20()inofcErc20Coins.ts: Placed intOfcErc20Coins(the test OFC array, after the lastofceth:entry). Token is test-only, sotOfcErc20Coinsis the correct array. The symbol'ofc:eth:tlto'follows the ticket specification exactly.'eth:tlto'enum position: Inserted alphabetically just before'eth:tlton'—tlto<tltonsince the prefix matches and the shorter string sorts first.Test plan
tsc --noEmiton@bitgo/staticspasses (no TypeScript errors)eslinton changed files passes (no lint errors)base.ts,erc20Coins.ts,ofcErc20Coins.tsmodified — no other files touchedOut of scope
None.
Ticket: SCAAS-10476