Verify Tesseract runtime before install - #59
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
Owner
Author
|
Independent adversarial re-check on current upstream base: reconfirmed the pinned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pinned Windows Tesseract runtime archive is downloaded into memory and, after the task succeeds, the installer removes the previous Windows binaries before unpacking the new runtime. The official support-files release publishes a SHA-256 digest, but the downloaded bytes are not authenticated before that destructive install step.
This change:
Tesseract553.zipValidation
SubtitleEdit/support-filesreleasetesseract553:fef2dbb1de8f25d660301c17aff107c0d9b0dc99e0d4f0eee938eb7238d7d2dcRemoveOldWindowsBinaries()only afterDownloadTesseractcompletes successfully, so integrity failure blocks the destructive stepBase is upstream
9be10e12d0f04655f2f134718b00679f89b2b15f.This PR supersedes internal draft #36.
AI assistance: ChatGPT was used to independently re-audit the Tesseract runtime download/install sequence on current upstream, reconfirm the support-files release digest, port the minimal integrity fix, and add regression coverage.