You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chatterbox model downloads currently use Hugging Face resolve/main URLs even though the code comments describe the Base V3 models as pinned. The GGUFs are also downloaded directly to their final paths, so a failed/partial download can leave a file that later existence checks treat as installed.
This change:
pins Base Chatterbox model URLs to immutable Hugging Face revision c45504bb8d55473a2213db17ec472ed11b69056a
pins Chatterbox Turbo model URLs to immutable Hugging Face revision b544cf8b49504d880640864a757b3ff3e4421a42
removes resolve/main from Chatterbox model downloads
downloads each GGUF to a same-directory .part path
publishes the final path only after the download completes successfully and cancellation is rechecked
removes stale/failed temporary files
preserves an existing final model if a replacement attempt fails
leaves model keys, file names, backend selection, quantizations and model contents unchanged
adds regressions for both immutable revision URLs, successful atomic publication, and failed-download preservation
Validation
current cstr/chatterbox-GGUF tree identifies revision c45504bb8d55473a2213db17ec472ed11b69056a as “Publish pinned Chatterbox Multilingual V3 GGUFs” and contains the V3 assets used by Subtitle Edit
current cstr/chatterbox-turbo-GGUF snapshot resolves to revision b544cf8b49504d880640864a757b3ff3e4421a42 and contains the Turbo Q8_0 assets used by Subtitle Edit
no SHA-256 claim is made for these Hugging Face/Xet model blobs; this PR establishes immutable repository revision identity and atomic local publication
initial CI run #34720170036 exposed a regression-test expectation bug: DownloadHelper retries and wraps repeated HTTP failures in InvalidOperationException
the regression was corrected to assert that public contract and preserve the original HttpRequestException as the inner cause
full solution restore passed after the correction
full solution build passed after the correction
full solution test suite passed on the first run after the correction
retry step was not used on the corrected run
validation run: #34720966219
Base is current upstream fa6d8623c2adb0c646b6d31a11b221b855339bbe.
AI assistance: ChatGPT was used to audit the Chatterbox model provenance/publication path, verify immutable Hugging Face revisions, prepare the minimal pin/atomic-publication fix, and add regression coverage.
Independent adversarial re-check completed after the regression-test correction. The Base and Turbo model URLs are pinned to verified immutable Hugging Face revisions c45504bb8d55473a2213db17ec472ed11b69056a and b544cf8b49504d880640864a757b3ff3e4421a42; model selection/file names remain unchanged; downloads stage to .part, preserve an existing destination until commit, re-check cancellation immediately before publish, and remove temporary files on failure. The earlier CI failure was a test expectation mismatch with DownloadHelper's documented retry/wrapping behavior, not a production defect. Corrected CI run #34720966219 passed restore/build/full tests on the first run with no retry. No blocker identified. Keep draft; no merge/promotion performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chatterbox model downloads currently use Hugging Face
resolve/mainURLs even though the code comments describe the Base V3 models as pinned. The GGUFs are also downloaded directly to their final paths, so a failed/partial download can leave a file that later existence checks treat as installed.This change:
c45504bb8d55473a2213db17ec472ed11b69056ab544cf8b49504d880640864a757b3ff3e4421a42resolve/mainfrom Chatterbox model downloads.partpathValidation
cstr/chatterbox-GGUFtree identifies revisionc45504bb8d55473a2213db17ec472ed11b69056aas “Publish pinned Chatterbox Multilingual V3 GGUFs” and contains the V3 assets used by Subtitle Editcstr/chatterbox-turbo-GGUFsnapshot resolves to revisionb544cf8b49504d880640864a757b3ff3e4421a42and contains the Turbo Q8_0 assets used by Subtitle EditDownloadHelperretries and wraps repeated HTTP failures inInvalidOperationExceptionHttpRequestExceptionas the inner causeBase is current upstream
fa6d8623c2adb0c646b6d31a11b221b855339bbe.AI assistance: ChatGPT was used to audit the Chatterbox model provenance/publication path, verify immutable Hugging Face revisions, prepare the minimal pin/atomic-publication fix, and add regression coverage.