Preserve installed plugin when cancellation wins before publish - #64
Draft
Blackspirits wants to merge 2 commits into
Draft
Preserve installed plugin when cancellation wins before publish#64Blackspirits wants to merge 2 commits into
Blackspirits wants to merge 2 commits into
Conversation
Blackspirits
commented
Sep 12, 2026
Blackspirits
left a comment
Owner
Author
There was a problem hiding this comment.
Independent adversarial re-check on current upstream base: the original destructive delete → cancellation-check ordering is still present in upstream; this patch moves the cancellation gate to the explicit publish commit point and deliberately stops observing cancellation after replacement begins, preventing a cancelled install from deleting the existing plugin without publishing the new one. Focused regressions cover cancellation-before-commit and normal replacement. Full current-base CI run #34721272791 passed restore/build/full tests on the first run with no retry. No blocker identified. Keep draft; no merge/promotion performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin installation currently has cancellation checks after deleting the existing installed plugin and again before moving the replacement into place. Cancellation can therefore win after the destructive delete and leave the user with no installed copy.
This change:
Validation
Base is upstream
fa6d8623c2adb0c646b6d31a11b221b855339bbe.This PR supersedes internal draft #16.
AI assistance: ChatGPT was used to independently re-audit the plugin install state transition on current upstream, isolate the destructive cancellation window, port the commit-point fix, and add regression coverage.