Reset current Settings.json from Windows installer - #67
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
Independent adversarial re-check on current upstream base: confirmed the installer still detects/deletes only legacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows installer reset task still checks/deletes only legacy
Settings.xml, while current Subtitle Edit settings are stored inSettings.json. Selecting reset can therefore leave the active settings untouched.This change:
Settings.jsonor legacySettings.xmlSettings.jsonwhen the reset task is selectedCurrent-base verification
fa6d8623c2adb0c646b6d31a11b221b855339bbeSubtitle_Edit_Installer.issis byte-for-byte identical between the reviewed internal PR Reset current Settings.json from Windows installer #18 base and current upstreamBase is current upstream
fa6d8623c2adb0c646b6d31a11b221b855339bbe.This PR supersedes internal draft #18.
AI assistance: ChatGPT was used to independently re-audit the installer reset path on current upstream, verify exact base-file identity, and port the compatibility-preserving fix without unrelated changes.