Skip to content

Allow explicit NTSC for VOB extraction - #68

Draft
Blackspirits wants to merge 1 commit into
fix/vob-multistream-overwrite-fa6dfrom
fix/vob-ntsc-after-overwrite-fa6d
Draft

Allow explicit NTSC for VOB extraction#68
Blackspirits wants to merge 1 commit into
fix/vob-multistream-overwrite-fa6dfrom
fix/vob-ntsc-after-overwrite-fa6d

Conversation

@Blackspirits

@Blackspirits Blackspirits commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

VOB extraction currently assumes PAL timing and frame geometry. There is no reliable PAL/NTSC auto-detection from VOB data alone without IFO parsing, so NTSC DVDs need an explicit CLI choice.

This follow-up builds on the current multi-stream overwrite fix and:

  • adds --vob-pal and --vob-ntsc
  • preserves PAL as the default for backwards compatibility
  • selects NTSC as 720x480 when explicitly requested
  • rejects conflicting PAL+NTSC flags
  • propagates the resolved video standard through ConversionOptions into VobSubExtractor
  • documents both flags in the CLI help
  • adds regressions for default PAL, explicit PAL, explicit NTSC and conflicting flags

Current-base verification

Dependency: internal PR #66 (validated; keep both drafts unmerged).

This PR supersedes internal draft #22.

AI assistance: ChatGPT was used to independently re-audit the PAL/NTSC limitation, verify exact base-file identity against the validated current overwrite fix, and port the isolated follow-up with its focused regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant