Allow explicit NTSC for VOB extraction - #68
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VOB extraction currently assumes PAL timing and frame geometry. There is no reliable PAL/NTSC auto-detection from VOB data alone without IFO parsing, so NTSC DVDs need an explicit CLI choice.
This follow-up builds on the current multi-stream overwrite fix and:
--vob-paland--vob-ntscConversionOptionsintoVobSubExtractorCurrent-base verification
fix/vob-multistream-overwrite-fa6d/ internal PR Protect multi-stream VOB outputs from accidental overwrite #66 so its diff contains only the video-standard behavior changeConvertCommand.cs,SubtitleConverter.cs,HelpDisplay.cs, andVobSubExtractorTest.csDependency: internal PR #66 (validated; keep both drafts unmerged).
This PR supersedes internal draft #22.
AI assistance: ChatGPT was used to independently re-audit the PAL/NTSC limitation, verify exact base-file identity against the validated current overwrite fix, and port the isolated follow-up with its focused regressions.