Verify FFmpeg downloads before install - #70
Draft
Blackspirits wants to merge 1 commit into
Draft
Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FFmpeg runtime archives are unpacked by the installer flow, and the current pinned support-files release exposes SHA-256 digests for each supported platform asset. This current-base port preserves the already-reviewed integrity fix exactly.
This change:
Current-base verification
FfmpegDownloadService.csis byte-for-byte identical between old review basec694526d77d92e98e5ed1449d4dbb1925a68adacand current upstream7dbf7e03c937241ff9511ae413d5552720249de1(blob0f7f61014505373f1f874ea4c11601280cf9cb73)SubtitleEdit/support-filesGitHub release asset digestsBase is current upstream
7dbf7e03c937241ff9511ae413d5552720249de1.This PR supersedes internal draft #24.
AI assistance: ChatGPT was used to independently verify exact base-file identity and transplant the already-reviewed FFmpeg integrity fix onto current upstream without modifying unrelated code.