Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/ui/Logic/Download/Qwen3AsrCppDownloadService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;
using Nikse.SubtitleEdit.UiLogic;

namespace Nikse.SubtitleEdit.Logic.Download;

Expand Down Expand Up @@ -59,6 +60,43 @@ public static bool IsVulkanBuildAvailable()
public async Task DownloadEngine(Stream stream, IProgress<float>? progress, CancellationToken cancellationToken, bool useVulkan = false)
{
await DownloadHelper.DownloadFileAsync(_httpClient, GetUrl(useVulkan), stream, progress, cancellationToken);
await VerifyArchiveAsync(stream, DownloadHashManager.ResolveQwen3AsrCppKey(useVulkan), cancellationToken);
}

internal static async Task VerifyArchiveAsync(Stream stream, string? key, CancellationToken cancellationToken)
{
if (string.IsNullOrEmpty(key))
{
throw new InvalidOperationException("No SHA-256 key is registered for this Qwen3 ASR build.");
}

var expected = DownloadHashManager.GetLatestKnownHash(key);
if (string.IsNullOrEmpty(expected))
{
throw new InvalidOperationException($"No SHA-256 is registered for Qwen3 ASR key '{key}'.");
}

if (!stream.CanRead || !stream.CanSeek)
{
throw new InvalidOperationException("Qwen3 ASR integrity verification requires a readable, seekable stream.");
}

string actual;
stream.Position = 0;
try
{
actual = await Sha256Util.ComputeSha256Async(stream, cancellationToken);
}
finally
{
stream.Position = 0;
}

if (!string.Equals(expected, actual, StringComparison.OrdinalIgnoreCase))
{
throw new IOException(
$"Qwen3 ASR download failed integrity check (expected SHA-256 {expected}, got {actual}).");
}
}

private static string GetUrl(bool useVulkan)
Expand Down
65 changes: 65 additions & 0 deletions tests/UI/Logic/Download/Qwen3AsrCppDownloadServiceTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
using System.Net;
using System.Text;
using Nikse.SubtitleEdit.Logic.Download;

namespace UITests.Logic.Download;

public class Qwen3AsrCppDownloadServiceTests
{
[Theory]
[InlineData(DownloadHashManager.Qwen3AsrCpp.Windows, "ad9c196aa52ceb42a3f46946644e4145fc7e297c84fa54e4cdf7fd9c22556300")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.WindowsVulkan, "a9971a24ba08765568c8a83a547924e42f15bd576b2cf594f6757fff66baf244")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.MacArm64, "a9e9f33ff8ba651591974824e886ecd28a034d00aaf8203365a7198cd5012325")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.MacX64, "6dbb978b74829c080177f6c70e89b363a8bc24d543b718ad06ecea7a7c833c53")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.Linux, "22b37a1917ca4083df7b57c62497a9f30c237ee13c2eee4b36a46320cf8506ed")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.LinuxVulkan, "d881e30dfc6f5311496355a08668d22d7f592ba4f7120a266abf8024d0f59a24")]
[InlineData(DownloadHashManager.Qwen3AsrCpp.LinuxArm64, "8d3a1ac745fa60f5576a6db599c7b4b9bc0302ea527cbdab9be3223f80a555e4")]
public void CurrentArchiveHash_MatchesV018ReleaseDigest(string key, string expected)
{
Assert.Equal(expected, DownloadHashManager.GetLatestKnownHash(key));
}

[Fact]
public async Task VerifyArchiveAsync_UnknownKey_FailsClosed()
{
await using var stream = new MemoryStream(Encoding.ASCII.GetBytes("abc"));

await Assert.ThrowsAsync<InvalidOperationException>(() =>
Qwen3AsrCppDownloadService.VerifyArchiveAsync(
stream,
"Qwen3AsrCpp.Unknown",
TestContext.Current.CancellationToken));
}

[Fact]
public async Task DownloadEngine_TamperedPayload_RejectsDownloadedBytes()
{
using var httpClient = new HttpClient(new StaticResponseHandler(Encoding.ASCII.GetBytes("tampered")));
var service = new Qwen3AsrCppDownloadService(httpClient);
await using var stream = new MemoryStream();

await Assert.ThrowsAsync<IOException>(() =>
service.DownloadEngine(
stream,
progress: null,
TestContext.Current.CancellationToken));

Assert.Equal(0, stream.Position);
}

private sealed class StaticResponseHandler(byte[] payload) : HttpMessageHandler
{
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
if (request.Method == HttpMethod.Head)
{
return Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK));
}

return Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK)
{
Content = new ByteArrayContent(payload),
});
}
}
}