Verify pinned Voikko dictionary downloads - #78
Draft
Blackspirits wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Finnish Voikko spell-check entry downloads two pinned assets from
SubtitleEdit/support-filesand immediately writes/unpacks them. This current-base port preserves the already-reviewed exact-URL SHA-256 verification and fail-closed policy.This change:
SubtitleEdit/support-filesVoikko releases until their exact URLs/hashes are registeredCurrent-base verification
SpellCheckDictionaryDownloadService.csis byte-for-byte identical between the old reviewed base and current upstream5e9ae4ff332010302cc5b584ef90226518d8dc5f(blob2fc8aba0652805299540ae6200c96996edaf054e)4e41605a3acd4b81e8212cb5138e74b13eff4250and test blob9a17758fdd50ed23910cbe64b9f7745297e6bca7were transplanted exactly onto the current upstream treelibvoikko-1.dllSHA-256:bfffd537ff372b425a61940d4f5ac6c80e2a745dab33cc00ac50e8f50441d1b0dict.zipSHA-256:98f26bb67e08288910fbf1aa92521f28bee79538ba86aefa267713333e7fa537Base is current upstream
5e9ae4ff332010302cc5b584ef90226518d8dc5f.This PR supersedes internal draft #52.
AI assistance: ChatGPT was used to verify exact base-file identity and transplant the already-reviewed Voikko integrity fix onto current upstream without modifying unrelated code.