docs: stop telling Solana users the Go SDK is Base-only - #20
Merged
Conversation
The FAQ said "The Go SDK supports Base chain only. For Solana, use the Python SDK or TypeScript SDK" — thirty lines after the Pay on Solana section documenting ten NewXClientSolana constructors. Solana shipped in 0.19.0; the FAQ predates it and was never updated. The FAQ is the page a user lands on when Solana misbehaves. Anyone who hit the paid-GET bug (#8, fixed in 0.19.2) read it, concluded Solana was unsupported in Go, and migrated away — for a bug with a one-line fix. Also corrects "every client has a NewXClientSolana counterpart" in the same breath: SurfClient and RPCClient do not (#12), and claiming otherwise sends the reader looking for a constructor that isn't there. Closes #11.
VickyXAI
pushed a commit
that referenced
this pull request
Aug 4, 2026
Ships the no-wallet guard hoist from #19 (closes #15). Also on main since 0.19.4, neither shipping library code: #20 corrects the README FAQ that told Solana users the Go SDK was Base-only, and #21 adds the release gate that flagged this very commit as missing. First release caught by that gate rather than by a human noticing the tag had fallen behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
What
README.mdcontradicted itself. The FAQ said:Thirty lines after the Pay on Solana section documenting ten
NewXClientSolanaconstructors.Solana shipped in 0.19.0. The FAQ line predates it (
cf4f0af) and was never updated.Why it matters more than a typo
The FAQ is the page a user lands on when Solana misbehaves. Anyone who hit the paid-GET bug from #8 — which broke every Solana GET for market data, dex, defi and prediction markets until 0.19.2 — read that FAQ, concluded Solana was unsupported in Go, and migrated to another SDK. For a bug with a one-line fix.
That is churn caused by documentation, and it is invisible in any bug tracker.
Also corrected
"Every client has a
NewXClientSolanacounterpart" in the Pay on Solana section.SurfClientandRPCClientdon't (#12), and the claim sends readers hunting for a constructor that isn't there. Now scoped to LLM and media clients with a pointer to the gap.Checks
sync-brand-numbers.mjs --checkpasses (README carriesbr:markers).#pay-on-solanaanchor resolves to## Pay on Solanaat line 126.Docs-only. No VERSION bump.