refactor: organized pages - #303
Open
Robert0Mart wants to merge 2 commits into
Open
Robert0Mart wants to merge 2 commits into
Robert0Mart wants to merge 2 commits into
Conversation
Robert0Mart
marked this pull request as ready for review
August 14, 2026 08:54
Robert0Mart
added
the
Refactor
1 task
gmmcosta15
self-requested a review
September 23, 2026 10:10
gmmcosta15
reviewed
Sep 23, 2026
Collaborator
There was a problem hiding this comment.
What's good
- 6 of the 7 moves are 100% renames; the 7th (
sensorsPanel.py) only has its one import line fixed, so review and rebase cost is minimal - Drops ~3.7k lines of unused
printStackedWidget.ui/_ui.py(no importers) test_job_status_page_unit.pyimport updated in the same PR- Import block stays isort-ordered, so ruff I001 stays quiet
- Groups the print-tab pages next to their only user,
printTab.py(checked: no other importers)
1. widgets/PrintTab/ has no __init__.py, but lib/panels/widgets/ does
Same as FilamentTab/ (#302) and ControlTab/ (#299).
touch BlocksScreen/lib/panels/widgets/PrintTab/__init__.py2. pyuic names still point at the deleted printStackedWidget.ui
printTab.py:504 setObjectName("printStackedWidget"), printTab.py:615 and PrintTab/tunePage.py:472 setWindowTitle(_translate("printStackedWidget", "StackedWidget")). A window title does nothing on a stacked page.
self.setObjectName("print_tab")
# delete both setWindowTitle(...) lines
RobeMartins
force-pushed
the
ref/printTab-stackedWidget
branch
from
September 25, 2026 09:25
d7ff146 to
41f8480
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR — merge order
This PR is stacked on top of:
Do not merge until #298 and #299 are merged first.
CI won't run here until the base becomes
dev(after the parents merge).Description
BlocksScreen/lib/panels/printTab.py
BlocksScreen/lib/panels/widgets/PrintTab/babystepPage.py
BlocksScreen/lib/panels/widgets/PrintTab/confirmPage.py
BlocksScreen/lib/panels/widgets/PrintTab/filesPage.py
BlocksScreen/lib/panels/widgets/PrintTab/jobStatusPage.py
BlocksScreen/lib/panels/widgets/PrintTab/sensorsPanel.py
BlocksScreen/lib/panels/widgets/PrintTab/sensorWidget.py
BlocksScreen/lib/panels/widgets/PrintTab/tunePage.py
BlocksScreen/lib/ui/printStackedWidget.ui
BlocksScreen/lib/ui/printStackedWidget_ui.py