BL-15958 Rename ebook theme to edge-to-edge, expand to all page sizes - #8262
BL-15958 Rename ebook theme to edge-to-edge, expand to all page sizes#8262hatton wants to merge 1 commit into
Conversation
Renames the zero-margin-ebook appearance theme to edge-to-edge and normalizes the old name as an alias wherever a theme name enters AppearanceSettings. The theme now applies to every page size, not just Ebook/Device layouts. Also fixes page-number placement for the theme, including full-bleed offsets, via --pageNumber-side-left/right-inset. Carved from the updated BL-15958-edge-to-edge-theme work (PR #7713). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
| Filename | Overview |
|---|---|
| src/BloomExe/Book/AppearanceSettings.cs | Normalizes the legacy theme alias on loading, assignment, and CSS generation, and updates explicit side-page-number formulas. |
| src/content/appearanceThemes/appearance-theme-edge-to-edge.css | Renames the theme, applies zero margins across page sizes, and introduces full-bleed text and page-number inset rules. |
| src/content/bookLayout/basePage.less | Adds an inset frame for top-level translation groups so full-bleed text can remain within the safe area. |
| src/content/bookLayout/pageNumbers.less | Refactors the full-bleed bottom offset into a separately composed CSS variable. |
| DistFiles/localization/en/BloomMediumPriority.xlf | Renames an established trans-unit ID, which breaks the repository’s localization identity and retirement workflow. |
| DistFiles/localization/es/BloomMediumPriority.xlf | Directly rewrites a Crowdin-owned locale while retaining an approved translation for the old theme meaning under the new key. |
| src/BloomTests/Book/AppearanceSettingsTests.cs | Updates expectations for canonical theme naming and the new page-number inset formulas. |
| src/BloomVisualRegressionTests/index.spec.ts | Replaces the old theme ID with the canonical ID in the visual-regression theme matrix. |
Reviews (1): Last reviewed commit: "BL-15958 Rename ebook theme to edge-to-e..." | Re-trigger Greptile
| </trans-unit> --> | ||
| <trans-unit id="AppearanceTheme.zero-margin-ebook" sil:dynamic="true"> | ||
| <source xml:lang="en">Zero Margin Ebook</source> | ||
| <trans-unit id="AppearanceTheme.edge-to-edge" sil:dynamic="true"> |
There was a problem hiding this comment.
Theme rename loses translations
When the updated catalog is synchronized with Crowdin or used in a non-English locale, replacing the established non-translate="no" trans-unit ID and directly rewriting translated catalogs loses the stable translation identity and associates old “Zero Margin Ebook” targets with the new “Edge to Edge” key. Preserve the old unit as obsolete and add the new unit only to the English catalog.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
[Claude Fable 5 following a prompt from Hatton]
Part 1 of 3 of the updated BL-15958 work, split out of #7713.
Tracker: BL-15958
What this does
zero-margin-ebookappearance theme toedge-to-edge.AppearanceSettingsnormalizes the old name as an alias, so existing books keep working.--pageNumber-side-left-inset/--pageNumber-side-right-insetplace side page numbers, with full-bleed offsets; the generated override formula also keeps master's--pageNumber-forced-side-extra-marginterm (BL-16695).appearance.jsonfiles, and the visual regression test theme list.Relationship to the other parts
Independent of the other two PRs; based on master. The siblings are the full-bleed page-size PR and the edit-mode crop-marks PR.
Verification
vite buildpasses.AppearanceSettingsTests,AppearanceMigratorTests, andBookTestsfixtures pass (243 tests).🤖 Generated with Claude Code
Devin review
This change is