Skip to content

BL-15958 Rename ebook theme to edge-to-edge, expand to all page sizes - #8262

Draft
hatton wants to merge 1 commit into
masterfrom
BL-15958-theme
Draft

BL-15958 Rename ebook theme to edge-to-edge, expand to all page sizes#8262
hatton wants to merge 1 commit into
masterfrom
BL-15958-theme

Conversation

@hatton

@hatton hatton commented Aug 31, 2026

Copy link
Copy Markdown
Member

[Claude Fable 5 following a prompt from Hatton]

Part 1 of 3 of the updated BL-15958 work, split out of #7713.

Tracker: BL-15958

What this does

  • Renames the zero-margin-ebook appearance theme to edge-to-edge. AppearanceSettings normalizes the old name as an alias, so existing books keep working.
  • Expands the theme from Ebook/Device layouts to every page size, in support of full-bleed print.
  • Fixes page-number placement for the theme. New CSS variables --pageNumber-side-left-inset / --pageNumber-side-right-inset place side page numbers, with full-bleed offsets; the generated override formula also keeps master's --pageNumber-forced-side-extra-margin term (BL-16695).
  • Updates the theme label in all localization files, template appearance.json files, and the visual regression test theme list.

Relationship to the other parts

Independent of the other two PRs; based on master. The siblings are the full-bleed page-size PR and the edit-mode crop-marks PR.

Verification

  • vite build passes.
  • The AppearanceSettingsTests, AppearanceMigratorTests, and BookTests fixtures pass (243 tests).

🤖 Generated with Claude Code

Devin review


This change is Reviewable

Renames the zero-margin-ebook appearance theme to edge-to-edge and
normalizes the old name as an alias wherever a theme name enters
AppearanceSettings. The theme now applies to every page size, not just
Ebook/Device layouts. Also fixes page-number placement for the theme,
including full-bleed offsets, via --pageNumber-side-left/right-inset.

Carved from the updated BL-15958-edge-to-edge-theme work (PR #7713).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR renames the zero-margin ebook appearance theme to Edge to Edge, normalizes the legacy theme ID, and extends its margin and page-number behavior to all page sizes.

  • Adds legacy-to-canonical theme-name normalization in AppearanceSettings.
  • Renames and broadens the appearance-theme CSS, including full-bleed text and page-number insets.
  • Updates templates, migration data, tests, and localization catalogs for the new theme name.

Important Files Changed

Filename Overview
src/BloomExe/Book/AppearanceSettings.cs Normalizes the legacy theme alias on loading, assignment, and CSS generation, and updates explicit side-page-number formulas.
src/content/appearanceThemes/appearance-theme-edge-to-edge.css Renames the theme, applies zero margins across page sizes, and introduces full-bleed text and page-number inset rules.
src/content/bookLayout/basePage.less Adds an inset frame for top-level translation groups so full-bleed text can remain within the safe area.
src/content/bookLayout/pageNumbers.less Refactors the full-bleed bottom offset into a separately composed CSS variable.
DistFiles/localization/en/BloomMediumPriority.xlf Renames an established trans-unit ID, which breaks the repository’s localization identity and retirement workflow.
DistFiles/localization/es/BloomMediumPriority.xlf Directly rewrites a Crowdin-owned locale while retaining an approved translation for the old theme meaning under the new key.
src/BloomTests/Book/AppearanceSettingsTests.cs Updates expectations for canonical theme naming and the new page-number inset formulas.
src/BloomVisualRegressionTests/index.spec.ts Replaces the old theme ID with the canonical ID in the visual-regression theme matrix.

Reviews (1): Last reviewed commit: "BL-15958 Rename ebook theme to edge-to-e..." | Re-trigger Greptile

Comment on lines 1172 to +1173
</trans-unit> -->
<trans-unit id="AppearanceTheme.zero-margin-ebook" sil:dynamic="true">
<source xml:lang="en">Zero Margin Ebook</source>
<trans-unit id="AppearanceTheme.edge-to-edge" sil:dynamic="true">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Theme rename loses translations

When the updated catalog is synchronized with Crowdin or used in a non-English locale, replacing the established non-translate="no" trans-unit ID and directly rewriting translated catalogs loses the stable translation identity and associates old “Zero Margin Ebook” targets with the new “Edge to Edge” key. Preserve the old unit as obsolete and add the new unit only to the English catalog.

Context Used: AGENTS.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant