Stop counting manual harnesses and by-hand launchers as skipped tests - #8311
Merged
Conversation
The nightly report showed 25 skipped component tests and 13 skipped C# tests, almost none of which were tests at all, which hid the few real skips that need work. - The five show-component manual harnesses are renamed *.manual.ts and collected only when show-component.sh sets PLAYWRIGHT_INCLUDE_MANUAL, instead of being skipped inside a normal run. - The by-hand dialog launchers in BloomTests (HelpLauncher, NewCollectionWizard, BloomPackInstaller, ProgressDialog, Configurator's ShowConfigureDialog) are deleted; they only opened dialogs a developer can open from Bloom itself. - ProxyManager's environment lookup is injectable, so the lowercase-wins precedence test runs on Windows too instead of being platform-excluded. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
andrew-polk
commented
Sep 4, 2026
andrew-polk
commented
Sep 4, 2026
Contributor
Author
|
[Claude Fable] Consulted Devin on 2026-09-04 20:40 UTC up to commit bc2ca6e. No bugs. Two Investigate flags, mirrored as review threads: the branch targets master rather than Version6.5 (left open for the developer to decide), and a |
andrew-polk
marked this pull request as ready for review
September 4, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The nightly report lists skipped tests per suite: last night 25 skipped React component tests and 13 skipped C# tests. Almost none of those were tests. They were manual harnesses and by-hand dialog launchers that a normal run can never execute, so the counts hid the handful of real skips that need work.
Fix.
show-component.uitest.tsmanual harnesses (BookGridSetup, color-picking, LinkTargetChooser, registration, CollectionTopBarControls) are renamedshow-component.manual.ts. The Playwright config collects*.manual.*only whenPLAYWRIGHT_INCLUDE_MANUAL=1, whichshow-component.shalready sets, so a normal run never sees them instead of skipping them. Their in-file env-var gating is removed.http_proxywins overHTTP_PROXYruns on Windows (fed from a dictionary) instead of being platform-excluded.Expected on the next nightly: React component skips 25 → 1, C# skips 13 → 4. The rest are real work.
Devin review
This change is