Regenerate the bloom-player baselines on a machine without Andika installed - #2
Merged
Merged
Conversation
…talled
bloom-player declares Andika with local("Andika") first, so a machine with
Andika installed renders the player with its own copy of the font. The previous
baselines came from such a machine. CI has no Andika and falls through to the
Bloom-served woff2, so every player page with text differed by tens to hundreds
of pixels of glyph shape. These 58 were rendered on a machine without Andika and
match CI pixel for pixel. The 14 other player pages and all book-preview
baselines already matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bloom-player declares Andika with local("Andika") first, so a machine with
Andika installed renders the player with its own copy of the font. The previous
baselines came from such a machine. CI has no Andika and falls through to the
Bloom-served woff2, so every player page with text differed by tens to hundreds
of pixels of glyph shape. These 58 were rendered on a machine without Andika and
match CI pixel for pixel. The 14 other player pages and all book-preview
baselines already matched.
BloomDesktop master already pins this commit (91149e54b). Compared with the previous pin (ffdd2e4), only the 58 bloom-player pages containing text change, by glyph shape alone: no image aligns better at a non-zero offset and no ink bounding box moves. Without the #8273 Chromium flags the same machine reproduces the pre-#8273 CI baselines (cd0df0a) pixel for pixel, so nothing but the font source changed.
🤖 Generated with Claude Code