Add fonts the font chooser e2e test installs on the nightly runner - #3
Open
JohnThomson wants to merge 1 commit into
Open
Add fonts the font chooser e2e test installs on the nightly runner#3JohnThomson wants to merge 1 commit into
JohnThomson wants to merge 1 commit into
Conversation
A GitHub Actions windows-latest runner has only Microsoft fonts and a few Bloom ships, so Bloom finds no font it calls unknown and no non-Microsoft font it calls unsuitable, and the font chooser test (BloomDesktop src/BloomE2E/tests/font-chooser.spec.ts, Notion test case 358) cannot run there. fonts/ now carries two genuinely free fonts that land in exactly those verdicts because of how their internal metadata is written: Alef (OFL; metadata says only 'All rights reserved') and Luciole (CC BY 4.0; a license statement Bloom's heuristics do not recognise). Each sits beside its upstream license text; fonts/README.md records the source, the license, and the verdict. The nightly workflow installs them per user before the suite. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fonts/with two fonts the BloomDesktop font chooser e2e test (Notion test case 358, BloomBooks/BloomDesktop#8289) needs installed on the nightly runner, which otherwise has only Microsoft fonts:Both are redistributable; the upstream license text sits beside each font and
fonts/README.mdrecords source, date, license, and verdict.manifest.jsongains afontssection.pnpm validatepasses.The BloomDesktop side (install script, workflow step, pin advance) is in BloomBooks/BloomDesktop#8289.
🤖 Generated with Claude Code