feat(sdk-tests): add SDK parity lint - #4125
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThis PR introduces ChangesSDK Parity Lint Tool and CI Integration
Cross-SDK Test Identifier Standardization
Estimated code review effort: 4 (Complex) | ~75 minutes Sequence Diagram(s)sequenceDiagram
participant run as tools/sdk-parity-lint/run
participant CLI as baml-cli run_ratchet
participant Scan as scan_all_sources
participant Discover as discover_tests
participant Inv as build_inventories
participant Report as build_parity_report_with_tests
participant Baseline as parse_baseline
participant Compare as compare_to_baseline
run->>CLI: invoke with repo_root/baseline/output
CLI->>Scan: run ast-grep per language
Scan->>Discover: AstMatch[] per source
Discover->>Inv: DiscoveredTest[]
Inv->>Report: SdkInventory[]
CLI->>Baseline: parse parity_analysis.md
Report->>Compare: current ParityReport
Baseline->>Compare: baseline ParityReport
Compare-->>CLI: outcome (worse/better/unchanged)
CLI-->>run: rendered markdown + exit code
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4eb750f580
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Binary size checks passed✅ 7 passed
Generated by |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 11
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc (1)
44-45: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winUse a declaration-level probe for the forward-referenced
Node.
forward_refs::Nodeis intentionally reference-only becauseclass Node { next Node }has no finite host-constructed value.sizeof(baml_sdk::forward_refs::Node)requires a complete type, so replace it with(void)&forward_refs::round_trip_node;intest_main.cc.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc` around lines 44 - 45, Replace the sizeof probe for baml_sdk::forward_refs::Node in test_main.cc with a declaration-level address probe using forward_refs::round_trip_node, while keeping the recursion::A sizeof probe unchanged.baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs (1)
15-30: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftExclude placeholder Rust tests from coverage accounting.
test_round_trip_rec_listandtest_round_trip_alias_containercarrysdk_test_idvalues but contain only comments; the Rust implementations for these alias roundtrips remain inexpressible. If the parity/discovery pipeline collects IDs from source, these placeholders should be excluded or marked unsupported/unimplemented so Rust coverage reports do not include them.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs` around lines 15 - 30, Exclude the comment-only placeholder tests test_round_trip_rec_list and test_round_trip_alias_container from Rust parity/discovery coverage accounting. Remove or mark their sdk_test_id entries as unsupported/unimplemented so the pipeline does not count these inexpressible alias roundtrips, while leaving executable tests unaffected.
🧹 Nitpick comments (3)
tools/sdk-parity-check/baml_src/pipeline.baml (2)
2-3: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPersonal machine paths hardcoded as the tool's canonical defaults.
pipeline.baml'smain()defaultsrepo_root/output_dirto one developer's local directory layout, andREADME.mddocuments/repeats those same paths (plus a private design-doc reference) as if they were portable defaults.
tools/sdk-parity-check/baml_src/pipeline.baml#L2-L3: replace/Users/sam/bamland/Users/sam/thoughts/sam-projects/bridge-codexwith repo-relative or environment-derived defaults (or drop the defaults and require explicit--repo_root/--output_dir).tools/sdk-parity-check/README.md#L3-L19: update the docs once the defaults change, and avoid citing a private, non-repo file path as the pipeline's spec reference.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/sdk-parity-check/baml_src/pipeline.baml` around lines 2 - 3, Replace the personal-machine defaults in main() for repo_root and output_dir with repo-relative or environment-derived values, or require both arguments explicitly. Update tools/sdk-parity-check/README.md lines 3-19 to document the new invocation/defaults and remove the private non-repository design-document reference.
17-27: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winInventory discovery is unbounded while diagnostics is capped by
codex_concurrency.The per-SDK inventory spawns (lines 17-27) run with no concurrency limit, unlike the diagnostics spawns (lines 37-52) which use a
TaskGroupcapped atcodex_concurrency. Consider applying the same group/limit to the inventory phase socodex_concurrencybounds Codex process concurrency consistently across both stages, especially as more SDK/environments are added.Also applies to: 37-52
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/sdk-parity-check/baml_src/pipeline.baml` around lines 17 - 27, The inventory discovery spawns in inventory_futures are unbounded; apply the same TaskGroup-based codex_concurrency limit used by the diagnostics spawns to this phase. Ensure each discover_sdk_inventory task remains validated and written through the existing flow while limiting concurrent Codex processes consistently across both stages.tools/sdk-parity-check/README.md (1)
3-3: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPersonal absolute paths baked into shared docs/defaults.
These docs reference machine-specific paths (
/Users/sam/baml,/Users/sam/thoughts/sam-projects/bridge-codex, and a private design doc) as if they were canonical. Other contributors running this tool must know to override every one of these on every invocation.Also applies to: 15-19
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/sdk-parity-check/README.md` at line 3, Update the sdk parity checker documentation and its defaults to remove machine-specific absolute paths, including references to /Users/sam/baml, the bridge-codex project, and the private design document. Replace them with repository-relative paths or configurable placeholders, and document any required override only when no portable default is possible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitignore:
- Line 195: Remove the repository-wide trailing “*” entry from .gitignore and
replace it with narrowly scoped patterns for the intended generated artifacts,
ensuring new source, test, and inventory files remain visible to Git.
In
`@baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.java`:
- Around line 33-35: Update the sdk_test_id comment above
test_round_trip_fizz_foo_bar to use the missing
type_shapes/symbol_collisions_round_trip_fizz_foo_bar inventory key, replacing
the duplicate fizz_buzz_foo_bar ID.
In `@codex-out/python-test-list.md`:
- Around line 35-37: Update the inventory command in the test-collection
transcript to handle the unsupported_only directory’s zero-test pytest result
explicitly: either skip that directory or accept pytest exit code 5 while
preserving failure handling for other errors. Ensure the resulting validation
reports successful inventory generation rather than treating the expected empty
suite as a failure.
- Line 3: Remove the absolute developer-local checkout path from the generated
metadata in codex-out/python-test-list.md at lines 3-3 and
codex-out/rust-test-list.md at lines 3-3; replace it with a repository-relative
path or omit the source-path metadata entirely.
In `@codex-out/test-coverage.md`:
- Line 69: Update the generated Markdown handling for the `_toHandle` and
`_fromHandle` identifiers in the bridge handles/media coverage output so
underscores cannot be interpreted as emphasis. Ensure these method names render
as inline code, or escape their underscores in the report generator, while
preserving the existing coverage content.
In `@codex-out/typescript_node-test-id.md`:
- Line 29: Update the generated test ID tokenization for the “rejects malformed
and overflowing IDs” case so the key uses the documented
namespace/dot-token/case-preserving join format and ends with “overflowing_ids”
rather than “overflowing_i_ds”. Regenerate the affected row from the source
annotation, then verify it matches corresponding cross-SDK test IDs.
In `@codex-out/typescript-node-test-list.md`:
- Line 3: Update the generated inventory provenance and collected test paths to
use repository-relative paths instead of machine-specific absolute paths such as
/Users/sam/baml. Remove the local username and workspace prefix while preserving
the referenced files and test entries.
In `@codex-out/typescript-web-test-list.md`:
- Line 3: Update the generation of codex-out/typescript-web-test-list.md to
normalize all embedded filesystem paths, including the line 3 host path and
Vitest results, to repository-relative paths by stripping the checkout prefix.
Ensure the regenerated artifact contains no absolute paths or local usernames.
In `@tools/sdk-parity-check/baml_src/codex.baml`:
- Around line 93-148: Pin the explicit model used by verify_test_file and
summarize_results when calling run_codex from discover_sdk_inventory and
explain_parity_gaps. Replace the null model argument in both calls with that
same model so --output-schema consistently receives structured output and
deserialization remains reliable.
In `@tools/sdk-parity-check/baml_src/tests.baml`:
- Around line 1-2: Update the test around extract_sdk_environments to avoid the
machine-specific “/Users/sam/baml” path. Resolve the repository root from the
test context or use a checked-in fixture/relative path so the test runs in any
checkout while preserving the existing SDK environment extraction behavior.
In `@tools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.json`:
- Around line 4-19: Update the root schema alongside diagnostics to support the
files_checked field emitted by render_diagnostics: add files_checked to required
and define it as an array whose items are non-empty strings. Preserve
additionalProperties: false and the existing diagnostics schema.
---
Outside diff comments:
In
`@baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc`:
- Around line 44-45: Replace the sizeof probe for baml_sdk::forward_refs::Node
in test_main.cc with a declaration-level address probe using
forward_refs::round_trip_node, while keeping the recursion::A sizeof probe
unchanged.
In
`@baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs`:
- Around line 15-30: Exclude the comment-only placeholder tests
test_round_trip_rec_list and test_round_trip_alias_container from Rust
parity/discovery coverage accounting. Remove or mark their sdk_test_id entries
as unsupported/unimplemented so the pipeline does not count these inexpressible
alias roundtrips, while leaving executable tests unaffected.
---
Nitpick comments:
In `@tools/sdk-parity-check/baml_src/pipeline.baml`:
- Around line 2-3: Replace the personal-machine defaults in main() for repo_root
and output_dir with repo-relative or environment-derived values, or require both
arguments explicitly. Update tools/sdk-parity-check/README.md lines 3-19 to
document the new invocation/defaults and remove the private non-repository
design-document reference.
- Around line 17-27: The inventory discovery spawns in inventory_futures are
unbounded; apply the same TaskGroup-based codex_concurrency limit used by the
diagnostics spawns to this phase. Ensure each discover_sdk_inventory task
remains validated and written through the existing flow while limiting
concurrent Codex processes consistently across both stages.
In `@tools/sdk-parity-check/README.md`:
- Line 3: Update the sdk parity checker documentation and its defaults to remove
machine-specific absolute paths, including references to /Users/sam/baml, the
bridge-codex project, and the private design document. Replace them with
repository-relative paths or configurable placeholders, and document any
required override only when no portable default is possible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4b35a6a6-52b1-4720-ae6d-421a9fc347cd
📒 Files selected for processing (180)
.gitignorebaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/go/function_calls/customizable/main_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdcodex-out/cpp-test-id.mdcodex-out/cpp-test-list.mdcodex-out/go-test-id.mdcodex-out/go-test-list.mdcodex-out/java-test-id.mdcodex-out/python-test-list.mdcodex-out/python_pydantic2-test-id.mdcodex-out/rust-test-id.mdcodex-out/rust-test-list.mdcodex-out/test-coverage.mdcodex-out/typescript-node-test-list.mdcodex-out/typescript-web-test-list.mdcodex-out/typescript_node-test-id.mdcodex-out/typescript_web_chromium-test-id.mdcodex-out/typescript_web_cloudflare_workers-test-id.mdtools/sdk-parity-check/README.mdtools/sdk-parity-check/baml.tomltools/sdk-parity-check/baml_src/codex.bamltools/sdk-parity-check/baml_src/discovery.bamltools/sdk-parity-check/baml_src/models.bamltools/sdk-parity-check/baml_src/pipeline.bamltools/sdk-parity-check/baml_src/render.bamltools/sdk-parity-check/baml_src/tests.bamltools/sdk-parity-check/baml_src/validate.bamltools/sdk-parity-check/schemas/discovered-tests.schema.jsontools/sdk-parity-check/schemas/parity-notes.schema.jsontools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.jsontools/sdk-parity-check/schemas/summary.schema.json
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 22, 2026 20:27
4eb750f to
f621844
Compare
sxlijin
had a problem deploying
to
boundary-tools-dev
July 22, 2026 20:27 — with 
GitHub Actions
Failure
GitHub Actions
Failure
sxlijin
temporarily deployed
to
boundary-tools-dev
July 22, 2026 20:27 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 855-868: Restrict the “Run SDK parity pipeline” step to approved
trusted executions before exposing CODEX_API_KEY, rather than running
PR-controlled tools/sdk-parity-check with the secret. Use a protected trusted
source or equivalent repository/actor/ref condition, and ensure untrusted PR
runs cannot access or execute this secret-backed step.
In
`@baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.py`:
- Line 30: The six corresponding Python and TypeScript streaming tests use
different IDs; make each pair identical for exact parity matching. Update
baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.py
at lines 30, 50, 70, 91, 112, and 133 and
baml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.ts
at lines 38, 59, 80, 98, 119, and 140 so each Python ID matches its
corresponding TypeScript test: streaming, async next_async, BAML collect,
typed-document next, typed-document async, and final-document collect.
In `@codex-out/typescript_web_chromium-test-id.md`:
- Line 55: Update the shared ID normalizer to tokenize acronyms correctly so
“IDs” becomes “ids” rather than “i_ds”, then regenerate both inventories. Ensure
codex-out/typescript_web_chromium-test-id.md:55 emits
function_calls/cancellation_rejects_malformed_and_overflowing_ids and
codex-out/typescript_web_cloudflare_workers-test-id.md:71 emits the same key.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 79066aed-5d1b-42f6-a2eb-bacd33576ff0
📒 Files selected for processing (182)
.github/workflows/ci.yaml.gitignorebaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/go/function_calls/customizable/main_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdcodex-out/cpp-test-id.mdcodex-out/cpp-test-list.mdcodex-out/go-test-id.mdcodex-out/go-test-list.mdcodex-out/java-test-id.mdcodex-out/python-test-list.mdcodex-out/python_pydantic2-test-id.mdcodex-out/rust-test-id.mdcodex-out/rust-test-list.mdcodex-out/test-coverage.mdcodex-out/typescript-node-test-list.mdcodex-out/typescript-web-test-list.mdcodex-out/typescript_node-test-id.mdcodex-out/typescript_web_chromium-test-id.mdcodex-out/typescript_web_cloudflare_workers-test-id.mdmise.tomltools/sdk-parity-check/README.mdtools/sdk-parity-check/baml.tomltools/sdk-parity-check/baml_src/codex.bamltools/sdk-parity-check/baml_src/discovery.bamltools/sdk-parity-check/baml_src/models.bamltools/sdk-parity-check/baml_src/pipeline.bamltools/sdk-parity-check/baml_src/render.bamltools/sdk-parity-check/baml_src/tests.bamltools/sdk-parity-check/baml_src/validate.bamltools/sdk-parity-check/schemas/discovered-tests.schema.jsontools/sdk-parity-check/schemas/parity-notes.schema.jsontools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.jsontools/sdk-parity-check/schemas/summary.schema.json
🚧 Files skipped from review as they are similar to previous changes (146)
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.ts
- tools/sdk-parity-check/schemas/parity-notes.schema.json
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.ts
- tools/sdk-parity-check/baml.toml
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.ts
- tools/sdk-parity-check/schemas/summary.schema.json
- baml_language/sdks/README.md
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.ts
- tools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.json
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.cc
- codex-out/rust-test-id.md
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rs
- codex-out/go-test-list.md
- tools/sdk-parity-check/schemas/discovered-tests.schema.json
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.ts
- baml_language/sdk_tests/crates/go/function_calls/customizable/main_test.go
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.cc
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.java
- tools/sdk-parity-check/README.md
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.ts
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.py
- baml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.py
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.java
- baml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rs
- codex-out/python-test-list.md
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.py
- baml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.ts
- tools/sdk-parity-check/baml_src/pipeline.baml
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rs
- tools/sdk-parity-check/baml_src/models.baml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.java
- codex-out/typescript-node-test-list.md
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.java
- baml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.go
- tools/sdk-parity-check/baml_src/validate.baml
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.py
- codex-out/rust-test-list.md
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.java
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py
- baml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.go
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.java
- baml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rs
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.py
- baml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.java
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.py
- .gitignore
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rs
- codex-out/cpp-test-list.md
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.py
- tools/sdk-parity-check/baml_src/tests.baml
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.py
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.cc
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.ts
- tools/sdk-parity-check/baml_src/render.baml
- tools/sdk-parity-check/baml_src/discovery.baml
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.java
- codex-out/typescript-web-test-list.md
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.java
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.py
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.ts
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 22, 2026 21:20
f621844 to
8802a46
Compare
sxlijin
temporarily deployed
to
boundary-tools-dev
July 22, 2026 21:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
codex-out/typescript_node-test-id.md (1)
29-29: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUse acronym-aware tokenization for the cancellation ID.
All three generated inventories split
IDsintoi_ds, so exact-ID parity joins can produce false coverage gaps.
codex-out/typescript_node-test-id.md#L29-L29: regenerate the row withfunction_calls/cancellation_rejects_malformed_and_overflowing_ids.codex-out/typescript_web_chromium-test-id.md#L55-L55: regenerate the row with the same corrected ID.codex-out/typescript_web_cloudflare_workers-test-id.md#L71-L71: regenerate the row with the same corrected ID.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@codex-out/typescript_node-test-id.md` at line 29, Regenerate the cancellation test inventory entries using acronym-aware tokenization so the ID remains “function_calls/cancellation_rejects_malformed_and_overflowing_ids” rather than splitting “IDs” into “i_ds”. Update codex-out/typescript_node-test-id.md at 29-29, codex-out/typescript_web_chromium-test-id.md at 55-55, and codex-out/typescript_web_cloudflare_workers-test-id.md at 71-71 with the corrected ID.codex-out/test-coverage.md (1)
69-69: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winEscape underscore-bearing identifiers in the shared Markdown renderer.
The same generated output exposes
_toHandleand_fromHandleas raw Markdown text, producing MD037 warnings and risking incorrect rendering.
codex-out/test-coverage.md#L69-L69: render the handle method names as escaped or inline-code text.codex-out/typescript_node-test-id.md#L202-L208: apply the same renderer fix and regenerate the inventory.codex-out/typescript_web_chromium-test-id.md#L166-L172: apply the same renderer fix and regenerate the inventory.codex-out/typescript_web_cloudflare_workers-test-id.md#L171-L177: apply the same renderer fix and regenerate the inventory.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@codex-out/test-coverage.md` at line 69, Update the shared Markdown renderer to escape or render the underscore-bearing _toHandle and _fromHandle identifiers as inline code, preventing MD037 warnings while preserving their displayed names. Regenerate codex-out/test-coverage.md:69, codex-out/typescript_node-test-id.md:202-208, codex-out/typescript_web_chromium-test-id.md:166-172, and codex-out/typescript_web_cloudflare_workers-test-id.md:171-177 using the corrected renderer.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py`:
- Around line 225-226: Update the parameterized test containing the
errors_clean_exit_terminates_process cases to use a single sdk_test_id for both
code=0 and code=7 parameters, or split them into separate test functions with
distinct IDs. Ensure each ID maps to exactly one test declaration and remove the
duplicate adjacent annotation.
In
`@baml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.ts`:
- Line 381: The equivalent optional-argument tests currently use different IDs
across SDKs; align them to shared canonical IDs. In
baml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.ts
at lines 381, 391, and 403, update the all-unset, partially-set-by-name, and
all-set test IDs respectively; in
baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.py
at lines 383, 393, and 406, retain or publish those same shared IDs.
In `@tools/sdk-parity-check/baml_src/pipeline.baml`:
- Around line 2-3: Update main’s repo_root and output_dir parameters to remove
the developer-specific /Users/sam defaults; require callers to provide both
paths or use portable repository-relative/CI-safe defaults, preserving explicit
argument behavior.
---
Duplicate comments:
In `@codex-out/test-coverage.md`:
- Line 69: Update the shared Markdown renderer to escape or render the
underscore-bearing _toHandle and _fromHandle identifiers as inline code,
preventing MD037 warnings while preserving their displayed names. Regenerate
codex-out/test-coverage.md:69, codex-out/typescript_node-test-id.md:202-208,
codex-out/typescript_web_chromium-test-id.md:166-172, and
codex-out/typescript_web_cloudflare_workers-test-id.md:171-177 using the
corrected renderer.
In `@codex-out/typescript_node-test-id.md`:
- Line 29: Regenerate the cancellation test inventory entries using
acronym-aware tokenization so the ID remains
“function_calls/cancellation_rejects_malformed_and_overflowing_ids” rather than
splitting “IDs” into “i_ds”. Update codex-out/typescript_node-test-id.md at
29-29, codex-out/typescript_web_chromium-test-id.md at 55-55, and
codex-out/typescript_web_cloudflare_workers-test-id.md at 71-71 with the
corrected ID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: fd6331ad-6619-44be-b0bf-73224a92c0d5
📒 Files selected for processing (182)
.github/workflows/ci.yaml.gitignorebaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/go/function_calls/customizable/main_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdcodex-out/cpp-test-id.mdcodex-out/cpp-test-list.mdcodex-out/go-test-id.mdcodex-out/go-test-list.mdcodex-out/java-test-id.mdcodex-out/python-test-list.mdcodex-out/python_pydantic2-test-id.mdcodex-out/rust-test-id.mdcodex-out/rust-test-list.mdcodex-out/test-coverage.mdcodex-out/typescript-node-test-list.mdcodex-out/typescript-web-test-list.mdcodex-out/typescript_node-test-id.mdcodex-out/typescript_web_chromium-test-id.mdcodex-out/typescript_web_cloudflare_workers-test-id.mdmise.tomltools/sdk-parity-check/README.mdtools/sdk-parity-check/baml.tomltools/sdk-parity-check/baml_src/codex.bamltools/sdk-parity-check/baml_src/discovery.bamltools/sdk-parity-check/baml_src/models.bamltools/sdk-parity-check/baml_src/pipeline.bamltools/sdk-parity-check/baml_src/render.bamltools/sdk-parity-check/baml_src/tests.bamltools/sdk-parity-check/baml_src/validate.bamltools/sdk-parity-check/schemas/discovered-tests.schema.jsontools/sdk-parity-check/schemas/parity-notes.schema.jsontools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.jsontools/sdk-parity-check/schemas/summary.schema.json
🚧 Files skipped from review as they are similar to previous changes (153)
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.java
- tools/sdk-parity-check/schemas/summary.schema.json
- tools/sdk-parity-check/baml.toml
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.ts
- baml_language/sdks/README.md
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs
- tools/sdk-parity-check/schemas/parity-notes.schema.json
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.ts
- tools/sdk-parity-check/schemas/discovered-tests.schema.json
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rs
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.py
- codex-out/rust-test-id.md
- baml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.cc
- codex-out/go-test-list.md
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.java
- .gitignore
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.java
- baml_language/sdk_tests/crates/go/function_calls/customizable/main_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.ts
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rs
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rs
- baml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.cc
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.ts
- baml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.java
- baml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.go
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.java
- tools/sdk-parity-check/baml_src/models.baml
- codex-out/python-test-list.md
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.java
- baml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.py
- mise.toml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.py
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.py
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rs
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.java
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.ts
- tools/sdk-parity-check/baml_src/validate.baml
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.py
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.cc
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.py
- tools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.json
- codex-out/rust-test-list.md
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.cc
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rs
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rs
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rs
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.java
- tools/sdk-parity-check/baml_src/tests.baml
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.java
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.ts
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.java
- codex-out/typescript-node-test-list.md
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rs
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.ts
- baml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.cc
- tools/sdk-parity-check/README.md
- tools/sdk-parity-check/baml_src/render.baml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.java
- codex-out/cpp-test-list.md
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.py
- tools/sdk-parity-check/baml_src/discovery.baml
- tools/sdk-parity-check/baml_src/codex.baml
- baml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rs
- .github/workflows/ci.yaml
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.py
- codex-out/typescript-web-test-list.md
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.py
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 22, 2026 21:48
8802a46 to
7ab238e
Compare
sxlijin
had a problem deploying
to
boundary-tools-dev
July 22, 2026 21:48 — with
GitHub Actions
Failure
GitHub Actions
Failure
sxlijin
temporarily deployed
to
boundary-tools-dev
July 22, 2026 21:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
codex-out/test-coverage.md (1)
69-69: 🗄️ Data Integrity & Integration | 🟡 MinorFix Markdown escaping for underscore-prefixed identifiers in the shared report generator.
These generated rows expose
_toHandleand_fromHandleas emphasis-like Markdown, causing MD037 and potentially incorrect rendering.
codex-out/test-coverage.md#L69-L69: escape or inline-code_toHandleand_fromHandle.codex-out/typescript_node-test-id.md#L202-L208: regenerate the bridge-handle rows with safe Markdown.codex-out/typescript_web_chromium-test-id.md#L166-L172: regenerate the bridge-handle rows with safe Markdown.codex-out/typescript_web_cloudflare_workers-test-id.md#L171-L177: regenerate the bridge-handle rows with safe Markdown.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@codex-out/test-coverage.md` at line 69, Update the shared report generator so underscore-prefixed identifiers such as _toHandle and _fromHandle are emitted with safe Markdown escaping or inline-code formatting. Regenerate the affected bridge-handle rows in codex-out/test-coverage.md:69-69, codex-out/typescript_node-test-id.md:202-208, codex-out/typescript_web_chromium-test-id.md:166-172, and codex-out/typescript_web_cloudflare_workers-test-id.md:171-177.Source: Linters/SAST tools
codex-out/typescript_node-test-id.md (1)
29-29: 🗄️ Data Integrity & Integration | 🟡 MinorFix acronym-aware ID normalization once, then regenerate all Web/Node inventories.
The shared normalizer splits
IDsintoi_ds, preventing exact joins against the intended stable ID.
codex-out/typescript_node-test-id.md#L29-L29: emitfunction_calls/cancellation_rejects_malformed_and_overflowing_ids.codex-out/typescript_web_chromium-test-id.md#L55-L55: emit the same corrected ID.codex-out/typescript_web_cloudflare_workers-test-id.md#L71-L71: emit the same corrected ID.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@codex-out/typescript_node-test-id.md` at line 29, Update the shared test-ID normalizer to preserve acronym-aware casing so “IDs” normalizes to “ids” rather than “i_ds,” then regenerate the affected inventories. Ensure codex-out/typescript_node-test-id.md:29-29, codex-out/typescript_web_chromium-test-id.md:55-55, and codex-out/typescript_web_cloudflare_workers-test-id.md:71-71 all emit function_calls/cancellation_rejects_malformed_and_overflowing_ids.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@codex-out/test-coverage.md`:
- Line 69: Update the shared report generator so underscore-prefixed identifiers
such as _toHandle and _fromHandle are emitted with safe Markdown escaping or
inline-code formatting. Regenerate the affected bridge-handle rows in
codex-out/test-coverage.md:69-69, codex-out/typescript_node-test-id.md:202-208,
codex-out/typescript_web_chromium-test-id.md:166-172, and
codex-out/typescript_web_cloudflare_workers-test-id.md:171-177.
In `@codex-out/typescript_node-test-id.md`:
- Line 29: Update the shared test-ID normalizer to preserve acronym-aware casing
so “IDs” normalizes to “ids” rather than “i_ds,” then regenerate the affected
inventories. Ensure codex-out/typescript_node-test-id.md:29-29,
codex-out/typescript_web_chromium-test-id.md:55-55, and
codex-out/typescript_web_cloudflare_workers-test-id.md:71-71 all emit
function_calls/cancellation_rejects_malformed_and_overflowing_ids.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f9577c62-d75e-4da3-8ed4-ba984e8b26a2
📒 Files selected for processing (182)
.github/workflows/ci.yaml.gitignorebaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/go/function_calls/customizable/main_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdcodex-out/cpp-test-id.mdcodex-out/cpp-test-list.mdcodex-out/go-test-id.mdcodex-out/go-test-list.mdcodex-out/java-test-id.mdcodex-out/python-test-list.mdcodex-out/python_pydantic2-test-id.mdcodex-out/rust-test-id.mdcodex-out/rust-test-list.mdcodex-out/test-coverage.mdcodex-out/typescript-node-test-list.mdcodex-out/typescript-web-test-list.mdcodex-out/typescript_node-test-id.mdcodex-out/typescript_web_chromium-test-id.mdcodex-out/typescript_web_cloudflare_workers-test-id.mdmise.tomltools/sdk-parity-check/README.mdtools/sdk-parity-check/baml.tomltools/sdk-parity-check/baml_src/codex.bamltools/sdk-parity-check/baml_src/discovery.bamltools/sdk-parity-check/baml_src/models.bamltools/sdk-parity-check/baml_src/pipeline.bamltools/sdk-parity-check/baml_src/render.bamltools/sdk-parity-check/baml_src/tests.bamltools/sdk-parity-check/baml_src/validate.bamltools/sdk-parity-check/schemas/discovered-tests.schema.jsontools/sdk-parity-check/schemas/parity-notes.schema.jsontools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.jsontools/sdk-parity-check/schemas/summary.schema.json
🚧 Files skipped from review as they are similar to previous changes (147)
- baml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.go
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.ts
- tools/sdk-parity-check/schemas/parity-notes.schema.json
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs
- baml_language/sdks/README.md
- tools/sdk-parity-check/schemas/summary.schema.json
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.ts
- tools/sdk-parity-check/schemas/sdk-test-id-diagnostics.schema.json
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.ts
- tools/sdk-parity-check/baml.toml
- codex-out/go-test-list.md
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.cc
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.ts
- codex-out/rust-test-id.md
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rs
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.ts
- tools/sdk-parity-check/schemas/discovered-tests.schema.json
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rs
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rs
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.java
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.py
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.py
- baml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.java
- baml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.ts
- baml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.go
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.py
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.py
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.py
- codex-out/python-test-list.md
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.ts
- codex-out/cpp-test-list.md
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rs
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.py
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.ts
- baml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.java
- mise.toml
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.py
- tools/sdk-parity-check/README.md
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.py
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.cc
- baml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.java
- .gitignore
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rs
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.cc
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.java
- tools/sdk-parity-check/baml_src/models.baml
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.cc
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rs
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.java
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.ts
- tools/sdk-parity-check/baml_src/pipeline.baml
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.py
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rs
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.java
- tools/sdk-parity-check/baml_src/validate.baml
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.java
- codex-out/typescript-node-test-list.md
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.py
- tools/sdk-parity-check/baml_src/discovery.baml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.cc
- tools/sdk-parity-check/baml_src/codex.baml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.java
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rs
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rs
- baml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.cc
- codex-out/rust-test-list.md
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.java
- baml_language/sdk_tests/crates/go/type_shapes/customizable/primitive_compile_test.go
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.py
- codex-out/typescript-web-test-list.md
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.py
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.ts
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.py
|
To use Codex here, create a Codex account and connect to github. |
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 22, 2026 22:42
7ab238e to
52b7875
Compare
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 23, 2026 22:28
70449a4 to
2ece788
Compare
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 24, 2026 00:08
2ece788 to
0682d49
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java (1)
171-177: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFix the asyncio timeout test to exercise cancellation.
future.get(50, TimeUnit.MILLISECONDS)throwsTimeoutExceptionwithout cancelling theCompletableFuture, and after the timeout the future remains active. Since this test is namedasync_cancel_via_asyncio_timeout, add the cancellation assertion/cleanup path or rename it to a timeout-only ID so parity doesn’t report a false cancellation match.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java` around lines 171 - 177, The test method test_cancellation_async_cancel_via_asyncio_timeout currently only times out without cancelling its CompletableFuture. Update the timeout handling to explicitly cancel future and assert successful cancellation before checking assertFastCancellation, or rename the test to reflect timeout-only behavior if cancellation is not intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.cc`:
- Line 12: Update the test identifiers in BAML_TEST declarations for
optional_args_optional_args_runtime_matrix and the corresponding async sample
test to remove the duplicated optional_args prefix, using
optional_args_runtime_matrix and optional_args_async_samples so the stable IDs
match cross-SDK baseline keys.
In `@baml_language/sdk_tests/crates/csharp/src/lib.rs`:
- Around line 5-7: Fix the C# crate test setup so cargo test --lib runs
successfully, including test_checked_in_union_runtime_source_matches_generator,
by ensuring the required C# union source generator is available and invoked
through the correct runtime or command configuration. Preserve the test’s
validation of checked-in generated union runtime source.
In
`@baml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.java`:
- Around line 48-49: Add the canonical // sdk_test_id: marker to every renamed
test method in TestErrors, specifically the methods at the listed locations,
using the IDs expected by SDK parity. Ensure the two clean-exit tests receive
distinct IDs and preserve each test’s existing behavior.
---
Outside diff comments:
In
`@baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java`:
- Around line 171-177: The test method
test_cancellation_async_cancel_via_asyncio_timeout currently only times out
without cancelling its CompletableFuture. Update the timeout handling to
explicitly cancel future and assert successful cancellation before checking
assertFastCancellation, or rename the test to reflect timeout-only behavior if
cancellation is not intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f7c8a807-d666-4f90-9796-f06278788e44
📒 Files selected for processing (93)
.baml/.gitignore.github/workflows/cargo-tests.reusable.yaml.github/workflows/ci.yaml.gitignore.pre-commit-config.yamlbaml_language/.markdown-whitelistbaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/csharp/src/lib.rsbaml_language/sdk_tests/crates/go/docstrings_etc/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/docstrings_etc/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_cancellation_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_errors_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_generics_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_host_callables_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_json_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_methods_on_classes_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_optional_args_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_reflected_type_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_static_methods_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_time_values_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_build_request_stream_companions_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_parse_companions_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_union_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_aliases_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_class_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_enums_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_forward_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_generics_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_lists_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_literals_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_maps_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_media_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_optional_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_primitives_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_recursion_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_routing_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_rust_type_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_streams_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_symbol_collisions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_unions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_void_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_complex_models_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_generic_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
🚧 Files skipped from review as they are similar to previous changes (7)
- baml_language/.markdown-whitelist
- .baml/.gitignore
- .pre-commit-config.yaml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.cc
- .gitignore
- .github/workflows/ci.yaml
- .github/workflows/cargo-tests.reusable.yaml
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 24, 2026 00:49
0682d49 to
ff45538
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rs (1)
33-38: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUpdate the stale test-name reference.
The comment still refers to
test_round_trip_rec_list, but the function is now namedtest_forward_refs_round_trip_rec_list.Proposed fix
- // `test_round_trip_rec_list` above. Intended body should a recursive + // `test_forward_refs_round_trip_rec_list` above. Intended body should a recursive🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rs` around lines 33 - 38, Update the stale test-name reference in the comment within test_forward_refs_round_trip_rec_list to use test_forward_refs_round_trip_rec_list instead of test_round_trip_rec_list; leave the surrounding explanation unchanged.
🧹 Nitpick comments (3)
tools/sdk-parity-lint/baml_src/parity.baml (1)
22-53: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicated per-environment inventory-building logic across two files.
build_inventories(parity.baml) andbuild_inventory_for(pipeline.baml) implement the same source-directory match, runtime filter, duplicate-ID detection,inventory_testpush, and sort. Keeping two copies risks divergence over time.
tools/sdk-parity-lint/baml_src/parity.baml#L22-L53: extract the per-env body into a shared helper (e.g.build_single_inventory(sdk_env, configs, tests)) and havebuild_inventoriescall it inside the env loop, keeping the cross-envrepresentedcompleteness check here.tools/sdk-parity-lint/baml_src/pipeline.baml#L11-L47: replacebuild_inventory_for's duplicated body with a call to that shared helper.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/sdk-parity-lint/baml_src/parity.baml` around lines 22 - 53, Extract the shared per-environment inventory logic from parity.baml#L22-L53 and pipeline.baml#L11-L47 into a helper such as build_single_inventory(sdk_env, configs, tests), preserving source-directory matching, runtime filtering, duplicate-ID validation, inventory_test creation, and sorting. Update build_inventories in parity.baml#L22-L53 to call the helper while retaining its cross-environment represented completeness check, and replace build_inventory_for in pipeline.baml#L11-L47 with the same helper call.tools/sdk-parity-lint/baml_src/tests.baml (1)
28-40: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
fixture_ast_matchalways points at the TypeScript fixture file, even for the C# test.
fixture_ast_matchhardcodesfileto the TypeScript sample path. The "audit coverage rejects C# wrappers..." test (Line 85) reuses this helper with acsharpSourceConfig, so the synthetic match'sfiledoesn't correspond to the C# fixture it's nominally testing. Consider parameterizingfile(or deriving it fromconfig.fixture_root/config.file_glob) so each test's synthetic match is self-consistent with the SDK under test.♻️ Proposed fix
-function fixture_ast_match(rule_id: string, start: int, end: int) -> AstMatch { +function fixture_ast_match(rule_id: string, start: int, end: int, file: string) -> AstMatch { AstMatch { text: "fixture test declaration", - file: "tools/sdk-parity-lint/test-fixtures/typescript/fixture/customizable/sample.test.ts", + file: file, range: AstRange {Also applies to: 82-92
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tools/sdk-parity-lint/baml_src/tests.baml` around lines 28 - 40, Update fixture_ast_match to accept the fixture file path as an argument and assign it to AstMatch.file instead of hardcoding the TypeScript path. Update every call site, including the C# audit-coverage test, to pass the path matching the SDK configuration under test..github/workflows/cargo-tests.reusable.yaml (1)
707-726: 🧹 Nitpick | 🔵 TrivialSingle hardcoded exclusion (
agent-docs) may need maintenance asbaml_language/sdks/grows.The coverage check treats any directory under
baml_language/sdks/other thanagent-docsas an SDK requiring a matrix entry. If a future non-SDK directory (docs, shared assets, etc.) is added there, this job will fail until it's added to the exclusion list. Consider a small explicit allowlist/denylist config, or a marker file convention, to keep this maintainable as the directory grows.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/cargo-tests.reusable.yaml around lines 707 - 726, Make SDK discovery in the coverage-check script maintainable by replacing the single hardcoded “agent-docs” exclusion with an explicit, centrally defined allowlist/denylist or marker-file convention for non-SDK directories. Update the sdkDirs filtering logic so only directories identified as SDKs require MATRIX_SDK_DIRS entries, while preserving the existing summary and missing-directory failure behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.java`:
- Around line 59-72: Add one exact sdk_test_id marker to every renamed test
declaration across
baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.java
(lines
59-72,84-96,108,117,126,137-144,159-165,175,191,202-215,224-252,262,272-308,317-335,345-360,380-385,405-410,419-432,443-453,467,489,498,512-517,529,543,561-571,581-595,606-615),
TestErrors.java (49,59,68,94-99,110,135-143,161,188-198, using distinct IDs for
both clean-exit tests), TestOptionalArgs.java (58,86,105, including the disabled
test), TestEnums.java (17-18,23-24,28-29,33-34,42), TestRecursion.java
(27-29,33-37,41-42,51), TestRouting.java
(30-31,35-36,41-43,47-49,53-55,59-61,65-67,71-73,77-78), TestStreams.java
(48,55,61,68,78, including
type_shapes/streams_round_trip_resume_or_http_response),
TestSymbolCollisions.java (26-29,33-37,41-43,51-53,62-64, preserving distinct
IDs including fizz_foo_bar), and TestUnions.java
(39-42,50-53,60-63,67-70,78-84,103-104,108-110); use the canonical category/name
IDs required by the parity pipeline.
In
`@baml_language/sdks/typescript/bridge_typescript/typescript_src/proto/baml_cffi.js`:
- Around line 264-266: Restore the guarded encodeDelimited generation used
across the TypeScript protobuf bindings: update the generator/template or
generation configuration so each encodeDelimited method, including the visible
InboundValue.encodeDelimited symbol, forks an already-allocated writer when
writer.len is present and otherwise uses the provided writer before applying
ldelim(). Regenerate all affected generated methods and verify the guarded
behavior is preserved consistently.
In `@tools/sdk-parity-lint/run`:
- Around line 21-31: Resolve the `--repo-root`, `--baseline`, and `--output`
paths against the caller’s original working directory before the script changes
directories. Update the argument-handling and `cd` flow in the run script so
BAML receives absolute or otherwise caller-relative-resolved paths, preserving
the documented behavior for invocations from the repository root.
---
Outside diff comments:
In
`@baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rs`:
- Around line 33-38: Update the stale test-name reference in the comment within
test_forward_refs_round_trip_rec_list to use
test_forward_refs_round_trip_rec_list instead of test_round_trip_rec_list; leave
the surrounding explanation unchanged.
---
Nitpick comments:
In @.github/workflows/cargo-tests.reusable.yaml:
- Around line 707-726: Make SDK discovery in the coverage-check script
maintainable by replacing the single hardcoded “agent-docs” exclusion with an
explicit, centrally defined allowlist/denylist or marker-file convention for
non-SDK directories. Update the sdkDirs filtering logic so only directories
identified as SDKs require MATRIX_SDK_DIRS entries, while preserving the
existing summary and missing-directory failure behavior.
In `@tools/sdk-parity-lint/baml_src/parity.baml`:
- Around line 22-53: Extract the shared per-environment inventory logic from
parity.baml#L22-L53 and pipeline.baml#L11-L47 into a helper such as
build_single_inventory(sdk_env, configs, tests), preserving source-directory
matching, runtime filtering, duplicate-ID validation, inventory_test creation,
and sorting. Update build_inventories in parity.baml#L22-L53 to call the helper
while retaining its cross-environment represented completeness check, and
replace build_inventory_for in pipeline.baml#L11-L47 with the same helper call.
In `@tools/sdk-parity-lint/baml_src/tests.baml`:
- Around line 28-40: Update fixture_ast_match to accept the fixture file path as
an argument and assign it to AstMatch.file instead of hardcoding the TypeScript
path. Update every call site, including the C# audit-coverage test, to pass the
path matching the SDK configuration under test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 77e616be-1998-4499-8d82-fd8fb312a5e5
⛔ Files ignored due to path filters (2)
baml_language/sdks/python/uv.lockis excluded by!**/*.lockbaml_language/sdks/typescript/bridge_typescript/dist/proto/baml_cffi.jsis excluded by!**/dist/**
📒 Files selected for processing (280)
.baml/.gitignore.github/workflows/cargo-tests.reusable.yaml.github/workflows/ci.yaml.gitignore.pre-commit-config.yamlbaml_language/.markdown-whitelistbaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/csharp/src/lib.rsbaml_language/sdk_tests/crates/go/docstrings_etc/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/docstrings_etc/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_cancellation_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_errors_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_generics_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_host_callables_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_json_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_methods_on_classes_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_optional_args_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_reflected_type_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_static_methods_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_time_values_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_build_request_stream_companions_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_parse_companions_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_union_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_aliases_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_class_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_enums_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_forward_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_generics_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_lists_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_literals_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_maps_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_media_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_optional_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_primitives_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_recursion_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_routing_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_rust_type_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_streams_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_symbol_collisions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_unions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_void_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_complex_models_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_generic_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/parity_analysis.mdbaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_callback_throws.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_cancellation.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_errors.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_generic_calls.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_host_callables.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_methods_on_classes.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_optional_args.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_raises.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_stdlib_entrypoints.rsbaml_language/sdk_tests/crates/rust/llm_functions/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/llm_functions/customizable/test_streaming_e2e.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_generics.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_handles.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_literals.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_media.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_streams.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_generic.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/swift/docstrings_etc/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestCancellation.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestErrors.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestGenericInference.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestHostCallables.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestMethodsOnClasses.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestOptionalArgs.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestStdlibEntrypoints.swiftbaml_language/sdk_tests/crates/swift/llm_functions/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/llm_functions/customizable/TestStreamingE2E.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestComplexModels.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestGenericMethods.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestAliases.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestClassRefs.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestEnums.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestForwardRefs.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestGenerics.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestHandles.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestLists.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestLiterals.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMaps.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMedia.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestOptional.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestPrimitives.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRecursion.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRouting.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestStreams.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestUnions.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestVoid.swiftbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdbaml_language/sdks/typescript/bridge_typescript/typescript_src/proto/baml_cffi.jsmise.tomlscripts/pr-unresolvedtools/sdk-parity-lint/README.mdtools/sdk-parity-lint/ast-grep-rules/cpp.ymltools/sdk-parity-lint/ast-grep-rules/csharp.ymltools/sdk-parity-lint/ast-grep-rules/go.ymltools/sdk-parity-lint/ast-grep-rules/java.ymltools/sdk-parity-lint/ast-grep-rules/python.ymltools/sdk-parity-lint/ast-grep-rules/rust.ymltools/sdk-parity-lint/ast-grep-rules/swift.ymltools/sdk-parity-lint/ast-grep-rules/typescript.ymltools/sdk-parity-lint/baml.tomltools/sdk-parity-lint/baml_src/annotations.bamltools/sdk-parity-lint/baml_src/ast_grep.bamltools/sdk-parity-lint/baml_src/baseline.bamltools/sdk-parity-lint/baml_src/config.bamltools/sdk-parity-lint/baml_src/models.bamltools/sdk-parity-lint/baml_src/normalize.bamltools/sdk-parity-lint/baml_src/parity.bamltools/sdk-parity-lint/baml_src/pipeline.bamltools/sdk-parity-lint/baml_src/render.bamltools/sdk-parity-lint/baml_src/tests.bamltools/sdk-parity-lint/baml_src/typescript.bamltools/sdk-parity-lint/runtools/sdk-parity-lint/test-fixtures/cpp/fixture/customizable/test_sample.cctools/sdk-parity-lint/test-fixtures/csharp/fixture/src/lib.rstools/sdk-parity-lint/test-fixtures/go/fixture/customizable/sample_test.gotools/sdk-parity-lint/test-fixtures/java/fixture/customizable/TestSample.javatools/sdk-parity-lint/test-fixtures/python/fixture/customizable/test_sample.pytools/sdk-parity-lint/test-fixtures/rust/fixture/customizable/test_sample.rstools/sdk-parity-lint/test-fixtures/swift/fixture/customizable/TestSample.swifttools/sdk-parity-lint/test-fixtures/typescript/fixture/customizable/sample.test.ts
🚧 Files skipped from review as they are similar to previous changes (95)
- baml_language/.markdown-whitelist
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_void_test.go
- .baml/.gitignore
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_complex_models_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_static_methods_test.go
- baml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_generic_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.ts
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_maps_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_aliases_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.ts
- baml_language/sdks/README.md
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_main_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.java
- .pre-commit-config.yaml
- baml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.go
- baml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.cc
- baml_language/sdk_tests/crates/go/docstrings_etc/customizable/go_codegen_edges_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.cc
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_optional_args_test.go
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rs
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_symbol_collisions_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_generics_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.cc
- .gitignore
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.java
- baml_language/sdk_tests/crates/go/llm_functions/customizable/test_build_request_stream_companions_test.go
- baml_language/sdk_tests/crates/go/llm_functions/customizable/test_parse_companions_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_lists_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.cc
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_cancellation_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_enums_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_class_refs_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_main_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_rust_type_test.go
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.cc
- baml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_recursion_test.go
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.cc
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.cc
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.ts
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_time_values_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_reflected_type_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_streams_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_media_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_json_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_union_edges_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.ts
- baml_language/sdk_tests/crates/go/docstrings_etc/customizable/test_main_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_literals_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.java
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_methods_on_classes_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/go_codegen_edges_test.go
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.ts
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.cc
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.java
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_primitives_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_unions_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java
- baml_language/sdk_tests/crates/csharp/src/lib.rs
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_generics_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.java
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.ts
- .github/workflows/ci.yaml
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.java
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.java
- baml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_edges_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.ts
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.py
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_routing_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_optional_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_errors_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_host_callables_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.py
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 24, 2026 05:04
ff45538 to
648f077
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py (1)
215-224: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winBound the subprocess wait.
If
DoExithangs or fails to terminate the child,subprocess.runwaits forever and can hang CI. Add a timeout and convertsubprocess.TimeoutExpiredinto a clear test failure.Proposed fix
result = subprocess.run( [sys.executable, "-c", _EXIT_SNIPPET.format(code=code)], capture_output=True, + timeout=30, )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py` around lines 215 - 224, Update _assert_clean_exit_terminates_process_with_code to pass a finite timeout to subprocess.run, catch subprocess.TimeoutExpired, and fail the test with a clear message when the child does not terminate; preserve the existing return-code and unreachable-output assertions for completed processes.baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py (1)
109-131: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUpdate the renamed test references in the explanatory comment.
Lines 130-131 still mention
test_one_type_arg_explicitandtest_two_type_args_explicit, but the declarations now use thetest_generic_calls_prefix. Update those references so the documentation points to the actual tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py` around lines 109 - 131, Update the explanatory comment in test_generic_calls_generic_free_fn_requires_binding to reference the renamed tests test_generic_calls_one_type_arg_explicit and test_generic_calls_two_type_args_explicit, leaving the test logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@baml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.ts`:
- Line 260: Rename the test title in the cancellation test from
“cancellation_rejects_malformed_and_overflowing_i_ds” to use “ids”, and update
the corresponding parity row to the same canonical identifier so parity analysis
matches the generated SDK naming.
---
Outside diff comments:
In
`@baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.py`:
- Around line 215-224: Update _assert_clean_exit_terminates_process_with_code to
pass a finite timeout to subprocess.run, catch subprocess.TimeoutExpired, and
fail the test with a clear message when the child does not terminate; preserve
the existing return-code and unreachable-output assertions for completed
processes.
In
`@baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.py`:
- Around line 109-131: Update the explanatory comment in
test_generic_calls_generic_free_fn_requires_binding to reference the renamed
tests test_generic_calls_one_type_arg_explicit and
test_generic_calls_two_type_args_explicit, leaving the test logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e5c99f6e-5ca2-4a7d-b4a6-417ca4dfd25b
⛔ Files ignored due to path filters (1)
baml_language/sdks/python/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (279)
.baml/.gitignore.github/workflows/cargo-tests.reusable.yaml.github/workflows/ci.yaml.gitignore.pre-commit-config.yamlbaml_language/.markdown-whitelistbaml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.ccbaml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_enums.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_literals.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.ccbaml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.ccbaml_language/sdk_tests/crates/csharp/src/lib.rsbaml_language/sdk_tests/crates/go/docstrings_etc/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/docstrings_etc/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_cancellation_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_errors_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_generics_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_host_callables_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_json_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_methods_on_classes_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_optional_args_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_reflected_type_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_static_methods_test.gobaml_language/sdk_tests/crates/go/function_calls/customizable/test_time_values_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_build_request_stream_companions_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/llm_functions/customizable/test_parse_companions_test.gobaml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_union_edges_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_aliases_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_class_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_enums_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_forward_refs_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_generics_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_lists_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_literals_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_maps_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_media_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_optional_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_primitives_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_recursion_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_routing_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_rust_type_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_streams_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_symbol_collisions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_unions_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_void_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_complex_models_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_generic_test.gobaml_language/sdk_tests/crates/go/type_shapes/customizable/test_main_test.gobaml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.gobaml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericCalls.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMain.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.javabaml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestMain.javabaml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestForwardRefs.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLiterals.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMedia.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestStreams.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.javabaml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.javabaml_language/sdk_tests/crates/parity_analysis.mdbaml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_calls.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.pybaml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_literals.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.pybaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.pybaml_language/sdk_tests/crates/rust/docstrings_etc/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_callback_throws.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_cancellation.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_errors.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_generic_calls.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_host_callables.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_methods_on_classes.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_optional_args.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_raises.rsbaml_language/sdk_tests/crates/rust/function_calls/customizable/test_stdlib_entrypoints.rsbaml_language/sdk_tests/crates/rust/llm_functions/customizable/test_main.rsbaml_language/sdk_tests/crates/rust/llm_functions/customizable/test_streaming_e2e.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_generics.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_handles.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_literals.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_media.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_streams.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_generic.rsbaml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rsbaml_language/sdk_tests/crates/swift/docstrings_etc/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestCancellation.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestErrors.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestGenericInference.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestHostCallables.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestMethodsOnClasses.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestOptionalArgs.swiftbaml_language/sdk_tests/crates/swift/function_calls/customizable/TestStdlibEntrypoints.swiftbaml_language/sdk_tests/crates/swift/llm_functions/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/llm_functions/customizable/TestStreamingE2E.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestComplexModels.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestGenericMethods.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/TestMain.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestAliases.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestClassRefs.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestEnums.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestForwardRefs.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestGenerics.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestHandles.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestLists.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestLiterals.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMaps.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMedia.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestOptional.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestPrimitives.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRecursion.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRouting.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestStreams.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestUnions.swiftbaml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestVoid.swiftbaml_language/sdk_tests/crates/typescript/docstrings_etc/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript/function_calls/customizable/web_sysops.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.tsbaml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.tsbaml_language/sdks/README.mdmise.tomlscripts/pr-unresolvedtools/sdk-parity-lint/README.mdtools/sdk-parity-lint/ast-grep-rules/cpp.ymltools/sdk-parity-lint/ast-grep-rules/csharp.ymltools/sdk-parity-lint/ast-grep-rules/go.ymltools/sdk-parity-lint/ast-grep-rules/java.ymltools/sdk-parity-lint/ast-grep-rules/python.ymltools/sdk-parity-lint/ast-grep-rules/rust.ymltools/sdk-parity-lint/ast-grep-rules/swift.ymltools/sdk-parity-lint/ast-grep-rules/typescript.ymltools/sdk-parity-lint/baml.tomltools/sdk-parity-lint/baml_src/annotations.bamltools/sdk-parity-lint/baml_src/ast_grep.bamltools/sdk-parity-lint/baml_src/baseline.bamltools/sdk-parity-lint/baml_src/config.bamltools/sdk-parity-lint/baml_src/models.bamltools/sdk-parity-lint/baml_src/normalize.bamltools/sdk-parity-lint/baml_src/parity.bamltools/sdk-parity-lint/baml_src/pipeline.bamltools/sdk-parity-lint/baml_src/render.bamltools/sdk-parity-lint/baml_src/tests.bamltools/sdk-parity-lint/baml_src/typescript.bamltools/sdk-parity-lint/runtools/sdk-parity-lint/test-fixtures/cpp/fixture/customizable/test_sample.cctools/sdk-parity-lint/test-fixtures/csharp/fixture/src/lib.rstools/sdk-parity-lint/test-fixtures/go/fixture/customizable/sample_test.gotools/sdk-parity-lint/test-fixtures/java/fixture/customizable/TestSample.javatools/sdk-parity-lint/test-fixtures/python/fixture/customizable/test_sample.pytools/sdk-parity-lint/test-fixtures/rust/fixture/customizable/test_sample.rstools/sdk-parity-lint/test-fixtures/swift/fixture/customizable/TestSample.swifttools/sdk-parity-lint/test-fixtures/typescript/fixture/customizable/sample.test.ts
🚧 Files skipped from review as they are similar to previous changes (250)
- .baml/.gitignore
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/test_generic.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_complex_models.rs
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_complex_models_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_primitives.cc
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_void.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_complex_models.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_generic.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_void.rs
- baml_language/sdk_tests/crates/go/unsupported_only/customizable/compile_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_lists.rs
- baml_language/.markdown-whitelist
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_generic.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_void.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_complex_models.py
- baml_language/sdk_tests/crates/go/docstrings_etc/customizable/go_codegen_edges_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_aliases.test.ts
- tools/sdk-parity-lint/ast-grep-rules/cpp.yml
- .gitignore
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_routing.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_aliases_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_symbol_collisions.cc
- tools/sdk-parity-lint/ast-grep-rules/go.yml
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_forward_refs_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/typemap.test.ts
- tools/sdk-parity-lint/test-fixtures/rust/fixture/customizable/test_sample.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_lists.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/methods_on_classes.test.ts
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_void_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_maps.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_enums.rs
- tools/sdk-parity-lint/test-fixtures/python/fixture/customizable/test_sample.py
- tools/sdk-parity-lint/ast-grep-rules/swift.yml
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_methods_on_classes.rs
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestForwardRefs.swift
- tools/sdk-parity-lint/baml_src/models.baml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_lists.cc
- tools/sdk-parity-lint/baml.toml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_void.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestVoid.java
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_errors.cc
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_media_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestHandles.java
- baml_language/sdks/README.md
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_class_refs.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_generics.py
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestHandles.swift
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_enums_test.go
- mise.toml
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_generic_test.go
- tools/sdk-parity-lint/test-fixtures/csharp/fixture/src/lib.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_stdlib_entrypoints.cc
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_recursion.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_forward_refs.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_symbol_collisions.test.ts
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestClassRefs.swift
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestComplexModels.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_routing.py
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/TestComplexModels.swift
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_generics.rs
- baml_language/sdk_tests/crates/cpp/docstrings_etc/customizable/tests/test_main.cc
- tools/sdk-parity-lint/ast-grep-rules/rust.yml
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_optional_args.rs
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_recursion.cc
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_stdlib_entrypoints.rs
- tools/sdk-parity-lint/ast-grep-rules/java.yml
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_optional.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_unions.test.ts
- tools/sdk-parity-lint/ast-grep-rules/python.yml
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_rust_type_test.go
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.py
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_streaming_e2e.py
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_cancellation_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestOptionalArgs.java
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestGenerics.swift
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_primitives.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/main.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_routing.rs
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_aliases.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_class_refs.test.ts
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_static_methods_test.go
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_streams.rs
- tools/sdk-parity-lint/test-fixtures/swift/fixture/customizable/TestSample.swift
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_handles.py
- baml_language/sdk_tests/crates/rust/llm_functions/customizable/test_streaming_e2e.rs
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_maps.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/test_main.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_optional_args.py
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_literals_test.go
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_recursion.py
- tools/sdk-parity-lint/README.md
- tools/sdk-parity-lint/test-fixtures/go/fixture/customizable/sample_test.go
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_media.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_recursion.test.ts
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestLists.swift
- tools/sdk-parity-lint/test-fixtures/typescript/fixture/customizable/sample.test.ts
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_optional.cc
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_main.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_surface.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_forward_refs.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.py
- baml_language/sdk_tests/crates/go/type_shapes/customizable/test_main_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_generics_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestEnums.java
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestPrimitives.swift
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_routing.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_class_refs.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/main.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRecursion.java
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_primitives.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_literals.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/runtime.test.ts
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestGeneric.java
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_enums.test.ts
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_unions.rs
- baml_language/sdk_tests/crates/java/llm_functions/customizable/TestStreamingE2e.java
- scripts/pr-unresolved
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRouting.swift
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_class_refs.cc
- baml_language/sdk_tests/crates/typescript/llm_functions/customizable/streaming_e2e.test.ts
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_media.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_enums.py
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_symbol_collisions.rs
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_optional.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_raises.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestUnions.java
- tools/sdk-parity-lint/ast-grep-rules/csharp.yml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestClassRefs.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_maps.cc
- baml_language/sdk_tests/crates/go/package_edges/customizable/compile_test.go
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/TestMain.swift
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_optional_args.cc
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestRecursion.swift
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_forward_refs.rs
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_symbol_collisions_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestAliases.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_unions.py
- baml_language/sdk_tests/crates/python_pydantic2/docstrings_etc/customizable/test_main.py
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_main_test.go
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestEnums.swift
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestStreams.swift
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/stdlib_entrypoints.test.ts
- tools/sdk-parity-lint/test-fixtures/java/fixture/customizable/TestSample.java
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_streams_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_lists_test.go
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_forward_refs.cc
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_primitives.py
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_optional.py
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestOptional.swift
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_streams.test.ts
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestMain.swift
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_handles.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestStdlibEntrypoints.java
- baml_language/sdk_tests/crates/go/llm_functions/customizable/test_parse_companions_test.go
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_generics.test.ts
- tools/sdk-parity-lint/baml_src/render.baml
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_unions.cc
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_callback_throws.rs
- baml_language/sdk_tests/crates/swift/llm_functions/customizable/TestMain.swift
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_time_values_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestCancellation.java
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_streams.py
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestStdlibEntrypoints.swift
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_maps_test.go
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_host_callables.cc
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestErrors.swift
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_aliases.cc
- .github/workflows/cargo-tests.reusable.yaml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestGenerics.java
- baml_language/sdk_tests/crates/parity_analysis.md
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_cancellation.cc
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMaps.swift
- tools/sdk-parity-lint/baml_src/pipeline.baml
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/cxx20/test_coawait.cc
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_stdlib_entrypoints.py
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestGenericInference.swift
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_json_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_unions_test.go
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_recursion_test.go
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestCancellation.swift
- tools/sdk-parity-lint/baml_src/typescript.baml
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/roundtrip_tests/test_maps.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestRaises.java
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestVoid.swift
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/roundtrip_handles.test.ts
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_class_refs_test.go
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/optional_args.test.ts
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/union_throws.test.ts
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_errors.rs
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.py
- baml_language/sdk_tests/crates/go/docstrings_etc/customizable/test_main_test.go
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_methods_on_classes.py
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_primitives_test.go
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_optional_args_test.go
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_aliases.py
- baml_language/sdk_tests/crates/swift/docstrings_etc/customizable/TestMain.swift
- baml_language/sdk_tests/crates/rust/llm_functions/customizable/test_main.rs
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_raises.py
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_optional_test.go
- tools/sdk-parity-lint/ast-grep-rules/typescript.yml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestOptional.java
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestSymbolCollisions.swift
- tools/sdk-parity-lint/baml_src/baseline.baml
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_cancellation.rs
- baml_language/sdk_tests/crates/typescript/type_shapes/customizable/bridge_handles_media.test.ts
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_generics_test.go
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestMethodsOnClasses.swift
- baml_language/sdk_tests/crates/go/llm_functions/customizable/test_build_request_stream_companions_test.go
- tools/sdk-parity-lint/baml_src/config.baml
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestUnions.swift
- baml_language/sdk_tests/crates/rust/type_shapes/customizable/test_main.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_main.cc
- baml_language/sdk_tests/crates/java/type_shapes/customizable/TestMain.java
- tools/sdk-parity-lint/baml_src/parity.baml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestPrimitives.java
- baml_language/sdk_tests/crates/cpp/type_shapes/customizable/tests/test_complex_models.cc
- baml_language/sdk_tests/crates/java/docstrings_etc/customizable/TestMain.java
- baml_language/sdk_tests/crates/go/function_calls/customizable/go_codegen_edges_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestMethodsOnClasses.java
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestMaps.java
- tools/sdk-parity-lint/baml_src/annotations.baml
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestLists.java
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_methods_on_classes_test.go
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestHostCallables.java
- tools/sdk-parity-lint/run
- baml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_lists.py
- .github/workflows/ci.yaml
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_errors_test.go
- baml_language/sdk_tests/crates/csharp/src/lib.rs
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestErrors.java
- baml_language/sdk_tests/crates/swift/function_calls/customizable/TestHostCallables.swift
- baml_language/sdk_tests/crates/typescript/function_calls/customizable/host_callables.test.ts
- baml_language/sdk_tests/crates/python_pydantic2/llm_functions/customizable/test_main.py
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_generic_calls.rs
- baml_language/sdk_tests/crates/go/type_shapes/customizable/go_codegen_union_edges_test.go
- tools/sdk-parity-lint/baml_src/ast_grep.baml
- baml_language/sdk_tests/crates/go/type_shapes/customizable/roundtrip_tests/test_routing_test.go
- baml_language/sdk_tests/crates/java/type_shapes/customizable/roundtrip_tests/TestRouting.java
- baml_language/sdk_tests/crates/go/llm_functions/customizable/test_main_test.go
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_host_callables.rs
- baml_language/sdk_tests/crates/cpp/function_calls/customizable/tests/test_methods_on_classes.cc
- baml_language/sdk_tests/crates/java/function_calls/customizable/TestGenericInference.java
- baml_language/sdk_tests/crates/rust/function_calls/customizable/test_raises.rs
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_host_callables.py
- baml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_generic_inference.py
- tools/sdk-parity-lint/baml_src/normalize.baml
- baml_language/sdk_tests/crates/swift/type_shapes/customizable/roundtrip_tests/TestMedia.swift
- baml_language/sdk_tests/crates/go/function_calls/customizable/test_reflected_type_test.go
- tools/sdk-parity-lint/baml_src/tests.baml
sxlijin
force-pushed
the
sam/sdk-parity-check
branch
from
July 24, 2026 16:42
648f077 to
aab4527
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SDK tests across all bridges use the same set of test names, and implement an sdk-parity-lint check that ensures we don't regress on parity.
Summary by CodeRabbit
Documentation
Quality Improvements