fix: make generated gitignore configurable - #4520
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe generator configuration now supports ChangesGenerated output writer
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change makes the generated .gitignore optional while preserving the current default behavior and supporting custom files on later generation; no actionable merge-blocking risk remains after normal checks. Sequence Diagram(s)sequenceDiagram
participant Manifest
participant CLI
participant Generator
participant OutputWriter
participant Filesystem
Manifest->>CLI: provide gitignore setting
CLI->>Generator: store gitignore policy
Generator->>OutputWriter: write generated output with options
OutputWriter->>Filesystem: create or preserve .gitignore
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
f12f67a to
0e62c85
Compare
Binary size checks passed✅ 7 passed
Generated by |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
gitignore = falsegenerator setting while preserving the current default.gitignorefiles on subsequent generationRoot cause
The shared SDK output writer always installed a catch-all
.gitignore, so a normalgit addof a generated crate silently staged only that file.Validation
cargo fmt --all -- --config imports_granularity="Crate" --config group_imports="StdExternalCrate"cargo clippy -p baml_cli --all-targets --all-features -- -D warningscargo test -p baml_codegen_types --libcargo test -p baml_cli --lib generator_gitignorecargo test -p baml_cli generate_rust_can_disable_generated_gitignore --test exit_code_e2ecargo test -p sdkgen_csharp --libFixes #4373