feat(atb2): the gate: fmt, clippy, changed-crate tests, nextest, insta, the baml corpus; judged by exit code - #4635
Draft
ATX24 wants to merge 1 commit into
Draft
Conversation
…ta, the baml corpus; judged by exit code The pipeline re-runs the repo's gate itself after the agent finishes; the agent's own claim is never trusted. Order and commands follow baml_language/TEST_INSTRUCTIONS.md: fmt --check, clippy -D warnings, `cargo test --lib` for each crate the agent touched, nextest on baml_tests with --no-fail-fast, insta --accept (gating on snapshot state, since verdicts were already taken by nextest), a tree-clean check, then baml-cli built and run over the BAML corpus. Known-flaky nextest failures (ATB2_FLAKY_TESTS, default the one test canary itself fails) are subtracted — but only when nextest exited 100 (compiled, ran, some tests failed). A compile error or a timeout exits otherwise and cannot be waved through on test-controllable output.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
This was referenced Aug 31, 2026
ATX24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipeline re-runs the repo's gate itself after the agent finishes; the
agent's own claim is never trusted. Order and commands follow
baml_language/TEST_INSTRUCTIONS.md: fmt --check, clippy -D warnings,
cargo test --libfor each crate the agent touched, nextest onbaml_tests with --no-fail-fast, insta --accept (gating on snapshot
state, since verdicts were already taken by nextest), a tree-clean
check, then baml-cli built and run over the BAML corpus.
Known-flaky nextest failures (ATB2_FLAKY_TESTS, default the one test
canary itself fails) are subtracted: but only when nextest exited 100
(compiled, ran, some tests failed). A compile error or a timeout exits
otherwise and cannot be waved through on test-controllable output.
Stack (bottom to top)
//#headersEach PR passes
baml check/baml fmt/baml teston its own; the top of the stack reproduces the reviewedbaml/feedback-part-3tools/atb2exactly. Supersedesbaml/feedback-part-3.