Skip to content

test(installer): add wrapper bootstrap e2e workflow - #4652

Closed
sxlijin wants to merge 20 commits into
canaryfrom
sxlijin/issue-4624-wrapper-e2e
Closed

test(installer): add wrapper bootstrap e2e workflow#4652
sxlijin wants to merge 20 commits into
canaryfrom
sxlijin/issue-4624-wrapper-e2e

Conversation

@sxlijin

@sxlijin sxlijin commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Stacked on #4632.

Adds an on-push workflow for exercising the wrapper bootstrap path without Fly.io:

  • invokes the reusable wrapper build and limits it to the four Linux targets under test
  • runs Bookworm and Alpine on native x86_64 and aarch64 GitHub runners
  • serves the checked-out install.sh and workflow-built wrapper artifact from a local manifest endpoint
  • verifies installer selection, wrapper execution, toolchain download, and real CLI init/check commands
  • includes a local runner that can consume downloaded artifacts or a GitHub Actions run ID

The reusable workflow target filter is optional; release callers still build the complete platform matrix by default.

Before/after evidence

Both runs cover Bookworm and Alpine on native x86_64 and aarch64 GitHub runners.

  • Before: published canary baseline — all four jobs fail with installer exit code 7. The canary installer selects the GNU wrapper on every Linux system; the canary wrapper requires GLIBC 2.38/2.39 on Bookworm and cannot find the glibc loader on Alpine.
  • After: PR install.sh and workflow-built wrappers — all four jobs pass through installer selection, wrapper execution, toolchain download, and real CLI init/check commands.

For GNU wrapper cases, the E2E fixture maps the toolchain artifact to the corresponding released musl CLI so the test isolates the wrapper ABI; the currently released GNU CLI also requires newer glibc and would otherwise confound the wrapper result.

Additional validation: actionlint, shell syntax checks, the existing Python test suite, and git diff checks.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
beps Ready Ready Preview Sep 1, 2026 12:29am UTC
promptfiddle2 Ready Ready Preview Sep 1, 2026 12:29am UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T00:28:10.262973Z 2e66570 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

⏭️ Performance benchmarks were skipped

Perf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to canary/main.

To run them on this PR, do any of the following, then push a commit (or re-run CI):

  • Add RUN_CODSPEED=1 to the PR description, or
  • Include run-perf or /perf in the PR title or any commit message.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 621886f7-6d59-49be-bac8-d963e6aa2945

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e66570049

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

on:
push:
branches:
- sxlijin/issue-4624-wrapper-e2e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger the E2E workflow beyond the temporary branch

When this change lands on main, or is pushed from any branch other than sxlijin/issue-4624-wrapper-e2e, GitHub's branch filter prevents the workflow from being scheduled. As a result, the newly added installer E2E coverage becomes dormant after the feature branch is removed; target a permanent branch or the intended pull-request event instead.

Useful? React with 👍 / 👎.

@vercel
vercel Bot temporarily deployed to Preview – promptfiddle2 September 1, 2026 00:29 Inactive
Base automatically changed from sxlijin/issue-4624-bookworm-installer to canary September 1, 2026 02:04
@sxlijin

sxlijin commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing the stacked E2E preparation PR as requested.

@sxlijin sxlijin closed this Sep 1, 2026
@sxlijin
sxlijin deleted the sxlijin/issue-4624-wrapper-e2e branch September 1, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant