test(installer): add wrapper bootstrap e2e workflow - #4652
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e66570049
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| push: | ||
| branches: | ||
| - sxlijin/issue-4624-wrapper-e2e |
There was a problem hiding this comment.
Trigger the E2E workflow beyond the temporary branch
When this change lands on main, or is pushed from any branch other than sxlijin/issue-4624-wrapper-e2e, GitHub's branch filter prevents the workflow from being scheduled. As a result, the newly added installer E2E coverage becomes dormant after the feature branch is removed; target a permanent branch or the intended pull-request event instead.
Useful? React with 👍 / 👎.
|
Closing the stacked E2E preparation PR as requested. |
Stacked on #4632.
Adds an on-push workflow for exercising the wrapper bootstrap path without Fly.io:
The reusable workflow target filter is optional; release callers still build the complete platform matrix by default.
Before/after evidence
Both runs cover Bookworm and Alpine on native x86_64 and aarch64 GitHub runners.
For GNU wrapper cases, the E2E fixture maps the toolchain artifact to the corresponding released musl CLI so the test isolates the wrapper ABI; the currently released GNU CLI also requires newer glibc and would otherwise confound the wrapper result.
Additional validation: actionlint, shell syntax checks, the existing Python test suite, and git diff checks.