Repository navigation
Fix miri errors for #58 - #59
Merged
Merged
Conversation
Switched MissAligner to work with a raw memory ptr to pas the borrow checks. Also fix some dealloc erros
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Kinda also doing this to rerun the checks since I cant run those on command and I wanna see if its not a one off kinda thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasn't quite handling the memory right in #58's emulation tests, this should fix them (and appease miri)
I believe the error on 450d6f4 is the callback being slow and its not yet pushed to the hashmap. I've upped the wait time and also change the assert to not rely on their being an entry to help identify should it happen again.