Rename scala classes being the same as entity classes in java - #542
Open
Wyrdix wants to merge 1 commit into
Open
Rename scala classes being the same as entity classes in java#542Wyrdix wants to merge 1 commit into
Wyrdix wants to merge 1 commit into
Conversation
Member
|
I have 2 big objections to this PR. First, it's broken because you forgot to add all the renamed Scala*Entity.scala files. And more important, I think that these files should be moved away from the build tree once the Scala entities are not used to template the exercise (ie once scala does remote execution as Java already does). These files should still exist, but in resources/ instead of in src/ Their only usage shall be to provide a correction that should be used by the tests to ensure that everything is still working. So, I guess that there is no point in fixing the first issue. Instead, we should convert Scala to remote execution and move these files out of the build tree. I fear it means that this PR should be dropped completely :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDE was throwing warning cause kotlin files, that are saved in the same file hierachy as java files, were named the same.