Conversation
iLauncherDev
reviewed
Sep 3, 2026
| bool drewSuccessfully = false; | ||
| if (glyph->sourceWidth != 0 && glyph->sourceHeight != 0) { | ||
| // Don't draw spaces (0x20) | ||
| if (ch == 0x20) { |
Contributor
Author
There was a problem hiding this comment.
only reason I did it like this was because fontAddSpriteImpl + html5 runner when drawing text check for spaces with 0x20
There was a problem hiding this comment.
and ' ' give the same value (0x20) but less magic
iLauncherDev
reviewed
Sep 4, 2026
| bool drewSuccessfully = false; | ||
| if (glyph->sourceWidth != 0 && glyph->sourceHeight != 0) { | ||
| // Don't draw spaces (0x20) | ||
| if (ch == 0x20) { |
There was a problem hiding this comment.
Suggested change
| if (ch == 0x20) { | |
| if (ch == ' ') { |
| bool drewSuccessfully = false; | ||
| if (glyph->sourceWidth != 0 && glyph->sourceHeight != 0) { | ||
| // Don't draw spaces (0x20) | ||
| if (ch == 0x20) { |
There was a problem hiding this comment.
Suggested change
| if (ch == 0x20) { | |
| if (ch == ' ') { |
There was a problem hiding this comment.
maybe you can remove the comment because the if will be self explanatory when you apply my suggestion
| bool drewSuccessfully = false; | ||
| if (glyph->sourceWidth != 0 && glyph->sourceHeight != 0) { | ||
| // Don't draw spaces (0x20) | ||
| if (ch == 0x20) { |
There was a problem hiding this comment.
Suggested change
| if (ch == 0x20) { | |
| if (ch == ' ') { |
| if (glyph != nullptr) { | ||
| bool resolveOk = true; | ||
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0) { | ||
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != 0x20) { |
There was a problem hiding this comment.
Suggested change
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != 0x20) { | |
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != ' ') { |
|
|
||
| bool resolveOk = true; | ||
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0) { | ||
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != 0x20) { |
There was a problem hiding this comment.
Suggested change
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != 0x20) { | |
| if (glyph->sourceWidth > 0 && glyph->sourceHeight > 0 && ch != ' ') { |
iLauncherDev
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Butterscotch still draws the space character if a sprite font has it in the string map
No clue if this causes any issues, and I've only tested the gl renderer
before:
after:
gms2 runner: