Android: option to handle physical controllers sideways - #540
Draft
GlitchedCode wants to merge 4 commits into
Draft
GlitchedCode wants to merge 4 commits into
GlitchedCode wants to merge 4 commits into
Conversation
GlitchedCode
marked this pull request as draft
September 15, 2026 21:04
GlitchedCode
force-pushed
the
physical_controller_sideways
branch
from
September 15, 2026 21:34
fdd2cb3 to
bc448d9
Compare
GlitchedCode
marked this pull request as ready for review
September 15, 2026 21:45
…ical controller layout
GlitchedCode
marked this pull request as draft
September 16, 2026 09:31
Author
|
currently has issues on my zeroranger fork. i suspect due to multiple inputs being simultaneously sent to the underlying VM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For games like shmups that benefit more from portrait orientation than landscape (e.g. ZeroRanger), it could be desirable to end users to have the possibility to handle telescopic controllers sideways (especially in cases such as the controller not fitting in a different orientation, or when using the USB-C port). This PR adds the
physicalControllerSidewaysoption to game setup and metadata related modules, and offers a basic implementation of this functionality throughGamepadRouter. If there's a better way to approach this last part any feedback is welcome.