Engine messages not going through

[stavrosfa]

This PR fixes a bug where, if you load a game where there are no more selectable (not busy) units, and you try for example to update the Domestic advisors' slider values ( I noticed the bug while working on #979), this will either lag a lot, or simply not go through at all.

I am not 100% sure why this is happening when a game is loaded like that, but not when we are in game and have no more selectable units, but I could see the engine sending a lot of MsgPerformUnitAction messages when the player is expected to simply end their turn.

So the main fix is to exit early from the UnitSelector's process when the blinker signal has been emitted.

If you want to reproduce it, load a game (I tried .SAV) where you have finished you turn and the blinker is on, and try to update the Domestic advisor's slider values.

Another thing I noticed was that we update the citizens' moods back to back, one in the MsgChangeSliders after updating the values, and then right after we send a new MsgUpdateUiAfterDomesticChange message wihch does the exact same thing and seems redundant, so I removed it.

[ajhalme]

Seems reasonable.

Maybe some of the animation stuff isn't getting loaded up right for "busy" units, like the worker digging a hole animation.

[stavrosfa]

Maybe some of the animation stuff isn't getting loaded up right for "busy" units

The animations have been like this for a very long time. It's an initialization issue, not how (or if) the animation is loaded. Have you noticed any animations missing or something?

like the worker digging a hole animation.

You mean the mining animation?! 😅