Skip to content

GameMenu rewiring, FileDialog tweaks - #986

Merged
ajhalme merged 2 commits into
C7-Game:Developmentfrom
ajhalme:game-menu-revisit
Aug 31, 2026
Merged

GameMenu rewiring, FileDialog tweaks#986
ajhalme merged 2 commits into
C7-Game:Developmentfrom
ajhalme:game-menu-revisit

Conversation

@ajhalme

@ajhalme ajhalme commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
  • Rewire GameMenu, use signals more consistently
  • Fix FileDialog UI event bugs, including Keyboard interacts with game when writing save file name #963
  • Fix focus bugs that result in Space key triggering buttons when wanting to end turn / skip unit after clicking menu
  • Widen FileDialog a bit, so it's less annoying to use

@stavrosfa stavrosfa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.
I have been working on having more consistent pop ups (with & without advisors) for some time now, but it will be a while before I actually push something.
The scrollbar PR I have opened is kinda part of that, so this is a good oppurtunity to ask, should we keep the Godot native file dialog, or should we re-create the one we see in the original?
I lean towards the latter, since we can have full control over looks & functionality.

@ajhalme

ajhalme commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Building a custom file dialog sounds like a hassle to me.

If anything, on UI matters, I feel like we should more bold in deviating from how things are done in Civ3.

@ajhalme
ajhalme merged commit 556d687 into C7-Game:Development Aug 31, 2026
3 checks passed
@ajhalme
ajhalme deleted the game-menu-revisit branch August 31, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants