GameMenu rewiring, FileDialog tweaks - #986
Merged
Merged
Conversation
ajhalme
commented
Aug 31, 2026
Contributor
- Rewire GameMenu, use signals more consistently
- Fix FileDialog UI event bugs, including Keyboard interacts with game when writing save file name #963
- Fix focus bugs that result in Space key triggering buttons when wanting to end turn / skip unit after clicking menu
- Widen FileDialog a bit, so it's less annoying to use
stavrosfa
approved these changes
Aug 31, 2026
stavrosfa
left a comment
Contributor
There was a problem hiding this comment.
This looks fine.
I have been working on having more consistent pop ups (with & without advisors) for some time now, but it will be a while before I actually push something.
The scrollbar PR I have opened is kinda part of that, so this is a good oppurtunity to ask, should we keep the Godot native file dialog, or should we re-create the one we see in the original?
I lean towards the latter, since we can have full control over looks & functionality.
Contributor
Author
|
Building a custom file dialog sounds like a hassle to me. If anything, on UI matters, I feel like we should more bold in deviating from how things are done in Civ3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.