Skip to content

Feature/deployment swey - #238

Open
Swe-yy wants to merge 47 commits into
devfrom
feature/deployment-swey
Open

Feature/deployment swey#238
Swe-yy wants to merge 47 commits into
devfrom
feature/deployment-swey

Conversation

@Swe-yy

@Swe-yy Swe-yy commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

setups production deployment for the application

Related issue

#222

How to test

navigate to the url https://www.codeclash.co.za/ and run through the app as a user

@Swe-yy
Swe-yy requested review from Ntuuu and nsmzoneli August 8, 2026 18:56

@morganthegirlboss morganthegirlboss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over this PR as requested of me and in terms of the work I do understand, everything looks correct and imports we shouldn't be using seem to have all been removed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these changes made for this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

becuase we're using an nginx proxy we don't need to spcify the websocket url, nginx handles the routing for us

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is only for deployment? Or is it needed for prod?

@nsmzoneli nsmzoneli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two players don't seem to be able to find one another when they queue. Is this intended behaviour? Please advise

@Swe-yy

Swe-yy commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Two players don't seem to be able to find one another when they queue. Is this intended behaviour? Please advise

I'm not sure what you mean. Is the matching not working on your machine?

@nsmzoneli

Copy link
Copy Markdown
Contributor

Two players don't seem to be able to find one another when they queue. Is this intended behaviour? Please advise

I'm not sure what you mean. Is the matching not working on your machine?

Yes, I followed the link, signed in two players, but they are not matching

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants