Skip to content

Backend and Frontend for Match History - #239

Open
nsmzoneli wants to merge 50 commits into
devfrom
feature/match-history-diso
Open

Backend and Frontend for Match History#239
nsmzoneli wants to merge 50 commits into
devfrom
feature/match-history-diso

Conversation

@nsmzoneli

@nsmzoneli nsmzoneli commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the backend services and controllers to be able to display a player's match history.

Related issue

How to test

  • Play a match between two players
  • Navigate to the dashboard for the match history
  • Also click a match row for more details

Swe-yy
Swe-yy previously requested changes Aug 11, 2026

@Swe-yy Swe-yy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

Comment thread backend/src/application/interfaces/repositories/IMatchRepository.ts
Comment thread backend/src/application/usecases/systems/finish-game.ts
Comment thread backend/src/application/usecases/systems/finish-game.ts
Comment thread backend/src/entities/db-entities/match-stats.entities.ts
Comment thread backend/src/entities/db-entities/match.entities.ts
Comment thread backend/tests/unit/usecases/finish-game.unit.test.ts Outdated
Comment thread backend/src/entities/db-entities/questions.entities.ts
Comment thread database/01-init.sql
@nsmzoneli
nsmzoneli requested a review from Swe-yy August 21, 2026 06:08
@nsmzoneli
nsmzoneli dismissed Swe-yy’s stale review August 21, 2026 06:29

Resolved all requested changes

@Swe-yy Swe-yy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you rolled back the achievement changes, however I'm still getting errors becuase there is no achievement table in the init.sql but one of the scripts is trying to populate that table.

Did you update the verifier in the auth service
I'm getting an error and the backend container is crashing

@nsmzoneli

Copy link
Copy Markdown
Contributor Author

I saw you rolled back the achievement changes, however I'm still getting errors becuase there is no achievement table in the init.sql but one of the scripts is trying to populate that table.

Did you update the verifier in the auth service I'm getting an error and the backend container is crashing

My bad!!! I forgot to remove that. I accidentally started working in this branch. I'll fix that. I don't remember touching the auth service but I will check it out. Did it crash when you tried to run docker compose up or do something else? @Swe-yy

@Swe-yy

Swe-yy commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

I saw you rolled back the achievement changes, however I'm still getting errors becuase there is no achievement table in the init.sql but one of the scripts is trying to populate that table.
Did you update the verifier in the auth service I'm getting an error and the backend container is crashing

My bad!!! I forgot to remove that. I accidentally started working in this branch. I'll fix that. I don't remember touching the auth service but I will check it out. Did it crash when you tried to run docker compose up or do something else? @Swe-yy

Yes the backend docker container won't start

@sonarqubecloud

Copy link
Copy Markdown

@nsmzoneli

Copy link
Copy Markdown
Contributor Author

I saw you rolled back the achievement changes, however I'm still getting errors becuase there is no achievement table in the init.sql but one of the scripts is trying to populate that table.
Did you update the verifier in the auth service I'm getting an error and the backend container is crashing

My bad!!! I forgot to remove that. I accidentally started working in this branch. I'll fix that. I don't remember touching the auth service but I will check it out. Did it crash when you tried to run docker compose up or do something else? @Swe-yy

Yes the backend docker container won't start

image That's so weird; it's working for me on my machine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants