Report styling: widget/text linewidth+sizes, double-click targets, draggable insets (0.4.0)#38
Merged
Merged
Conversation
Previously only ArrowWidget accepted linewidth; circle/rect/annular/ crosshair/polygon and the 1D vline/hline/range/point widgets hardcoded a 2px stroke in the JS renderer. Add a linewidth kwarg (default 2) stored in _data on every widget class and forwarded by the add_*_widget factories; the JS drawOverlay honors it. Round-trips through widget.set/to_dict with no allowlist changes.
Add Plot1D.set_legend_fontsize(size) writing a legend_fontsize state key (the JS legend was a hardcoded 10px monospace); the renderer scales the legend rows to match. Also thread the new linewidth kwarg through the 1D add_vline/hline/range/point widget factories.
…ing 0.4.0 work)
These source files interleave this change's two features with pre-existing
uncommitted 0.4.0 work already in the tree, so they land together.
New this session:
- double_click events carry an optional `target` field ('title'/'x_label'/
'x_ticks'/'y_label'/'y_ticks'/'legend'/'colorbar_label') via dblclick
listeners on the axis/colorbar/title canvases + 1D gutter/legend hit-tests;
Event gains `target`. Plot-area double_click stays untagged (back-compat).
- InsetAxes native drag + corner-resize when edit_chrome is on: dragging the
body moves (corner->anchor on first move), a bottom-right grip resizes, and
pointerup emits a figure-level `inset_geometry_change {inset_id, anchor,
w_frac, h_frac}`. InsetAxes.set_geometry() + dispatch branch + Event fields.
Pre-existing (already in the working tree, not authored this session): layer
tint (LayerSpec.tint / add_layer(tint=)), InsetAxes.indicate_point, and the
3D exportPNG fix. Their towncrier fragments are included.
An inset with no title (the default) now hides its title-bar strip entirely instead of rendering a useless empty header — the content div fills the whole box, a clean bordered plot. Every layout computation that used to read the raw INSET_TITLE_H constant (drag/resize clamps, corner/anchor stacking) now goes through _insetTitleH(spec), which returns 0 for a title-less inset, so its box height equals its content height with no phantom gap. A titled inset is unchanged: bar renders, click still toggles minimize. A title-less inset has no minimize affordance (nothing to click), but drag-to-move/resize in edit mode still works since those gestures are wired on insetDiv itself, not the title bar. Guard added so a stray 'minimized' state on a title-less inset falls back to normal instead of collapsing to zero height. Extends test_inset_callout.py with DOM/behaviour coverage: default and explicit empty/whitespace title hide the bar; non-empty title keeps it and its click-to-minimize; title-less inset body-drag still moves it.
…uto-hide Two CI failures on the PR: - Docs (-W): the Event docstring's new 'target' field wrapped its description across indented continuation lines, which docutils flagged as 'Unexpected indentation'. Collapse it (and the new panel-swap / inset-geometry field entries) to single lines matching the existing fields; verified the docstring now parses clean through docutils. - Tests: test_inset_title_drawn_in_titlebar_band assumed an empty-title inset still has a titlebar band to diff against, but the title-bar auto-hide feature removed it. Rewrite it to (a) assert a titled inset draws text in its band (vs a text-free baseline row) and (b) a new test asserting an empty-title inset has NO band. Both pass in headless chromium.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 90.18% 90.38% +0.20%
==========================================
Files 39 39
Lines 3902 3994 +92
==========================================
+ Hits 3519 3610 +91
- Misses 383 384 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Report-styling and interactive-inset features, targeting the 0.4.0 release. These are the anyplotlib-side capabilities behind SpyDE's report builder polish (widget/text styling, draggable callout insets, double-click-to-edit chrome), plus a few 0.4.0 items that were already staged on this working branch.
New features
Widget & text styling
linewidth=on every overlay widget — every 2-D and 1-D overlay widget constructor andadd_*_widgetfactory (rectangle, circle, annular, crosshair, polygon, vline, hline, range, point) now takes alinewidth(px, default 2), stored and round-tripped likecolor. Previously onlyArrowWidgethonored a linewidth; the others hardcoded a 2px stroke in the renderer.Plot1D.set_legend_fontsize()— control the 1-D legend text size (was a hardcoded 10px).Double-click-to-edit chrome
double_clickEventgains atargetfield naming which text element was hit ('title','x_label','x_ticks','y_label','y_ticks','colorbar_label','legend'), so a host can open the right editor for a label vs. ticks vs. legend. 2-D panels hit-test the separate axis/title/colorbar canvases; 1-D panels zone-split the single canvas around the plot rect and legend box. A plain plot-area double-click is unchanged and carries notarget(fully back-compatible).Interactive insets
edit_chromemode: drag the body to move (a corner-stacked inset converts to a free anchor and its siblings re-stack), drag the bottom-right grip to resize (min 64px/dim). On release the renderer emits a figure-levelinset_geometry_changeevent with the finalanchor/w_frac/h_frac, observable viaadd_event_handlerto persist layout. The same geometry can be set programmatically via the newInsetAxes.set_geometry(). Off edit mode the affordances are hidden and the inset is inert.add_inset(title="")(the default) now renders as a clean bordered plot box with content filling the whole area, instead of a useless empty header strip. Titled insets are unchanged (bar + click-to-minimize); title-less insets keep drag-to-move/resize (those gestures are on the body, not the bar).Also in this release (already staged on the branch before this work)
indicate_point()— the point sibling ofindicate_region(): a marker at a parent data point plus a leader line to the inset.add_layer(tint=)/Layer.set(tint=)— render a layer as a clear→colour intensity ramp (256×4 RGBA LUT) instead of a named colormap;cmap=reverts.scatter3d/voxels) no longer composite as blank rectangles; the 3-D pass is re-rendered synchronously before readback.Changelog
Towncrier fragments added under
upcoming_changes/(orphan+slugform) for every item above.towncrier build --draft --version 0.4.0renders a clean 0.4.0 section (7 New Features + 1 Bug Fix).Tests
New/extended coverage across the affected suites:
test_widgets(per-widget linewidth),test_label_api(legend fontsize),test_callbacks_unit/test_callbacks_playwright(double-click targets),test_inset/test_inset_callout(set_geometry,inset_geometry_changeround-trip, title-bar auto-hide, real Playwright drag). The full suite passes (1600+ passed / the standard skips); the double-click and drag paths are exercised in real headless Chromium.