fix: avoid null logger dereference in error dialogs - #70
Open
aminya wants to merge 1 commit into
Open
Conversation
This fixes the spdlog logger null pointer deference when an exception is thrown. The logger is initialized before all paths now
aminya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the spdlog logger null pointer deference when an exception is thrown when an error dialog is shown. The logger is initialized before all paths now. This means all the error dialogs are shown properly
For example,
!alpm::is_valid_alpm_dbs()callsspdlogin catch before spdlog is initialized resilting in segmentation faulthttps://github.com/aminya/packageinstaller/blob/077021749fe83765ab2b7b844838188f1eec4066/src/alpm_manager.cpp#L178-L185
Before:
After:
After fixing the issue that's now visible in the dialog:
