Repair multiseed and canonical resume orchestration#84
Open
charlesmartin14 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
git_commit,git_dirty,weightwatcher_version,wwpgd_commit,torch_version, andoptimizer_implementation_version. (src/wwgpt/train.py,src/wwgpt/checkpointing.py)_select_resume_runto classify runs ascomplete,resume, ornew, verify checkpoint integrity and completion markers, skip verified completed runs, resume a single compatible incomplete run, create a new append-only run when none exists, and fail with an explicit ambiguity error if multiple compatible incomplete runs exist. (src/wwgpt/train.py)assert_checkpoint_compatiblereturn mismatches and acceptallow_code_version_mismatchso code-version fields may be permitted while other scientific mismatches remain blocking; when allowed, mismatches are recorded to a persistent audit JSON and mark runs non-publication-eligible unless an explicit audit override is supplied. (src/wwgpt/checkpointing.py,src/wwgpt/train.py,src/wwgpt/integrity.py)--allow-code-version-mismatchsupport and a new--audit-override-code-version-mismatchflag in the CLI and propagated the audit override throughrun-multiseedandrun-canonical-trials. (src/wwgpt/cli.py,src/wwgpt/train.py)code_version_mismatch_*.jsonandaudit_*checks inintegritydetect unaudited mismatches to exclude runs from publication eligibility. (src/wwgpt/integrity.py)Testing
pytest -q, which completed successfully (tests passed; some tests skipped for environment specifics).pytest -q tests/test_critical_fixes.py tests/test_wwpgd_training_cadence.py tests/test_canonical_trials.pyandpytest -q tests/test_canonical_trials.py tests/test_wwpgd_training_cadence.py tests/test_cli_execution_interface.py tests/test_integrity_publication_grade.py, which passed (targeted tests green).python -m py_compile src/wwgpt/train.py src/wwgpt/checkpointing.py src/wwgpt/cli.pyandgit diff --check, both succeeded.Codex Task