Update unicode-width to 0.2.2. - #82
Merged
Merged
Conversation
This has a slighty behavioral change, in that `\n` is now treated as width 1 (unicode-rs/unicode-width#60). However, as the `unicode-width` docs point out: "Relying on any character producing a stable width in this crate is likely the sign of a bug." None of our tests fail with this change.
Owner
|
Ouch... There's a lot to check for this "slight behavorial difference"... |
Contributor
Author
|
Are there tests (either existing or to be added) which are would demonstrate the kinds of checks required for this change? |
Owner
I don't think there's any breakage, lines are split before measuring and it looks like no code using termimad's normal APIs measures lines with LF kept. But no, you can't really add a test to check that unicode-width returns a zero width for newlines. |
Owner
|
I'll probably merge this this week-end (and maybe reexport the lib so that programs can use the same version) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a semver-incompatible change and has a slight behavioral behavioral difference, in that
\nis now treated as width 1 (unicode-rs/unicode-width#60). However, as theunicode-widthdocs point out: "Relying on any character producing a stable width in this crate is likely the sign of a bug."None of our tests fail with this change.