Skip telemetry writes when no database is configured - #66
Conversation
With no `database` in the controller config, every metrics poll built an engine from the string "None", so SQLAlchemy raised "Could not parse SQLAlchemy URL from given URL string" once per instance every 5 seconds. Telemetry has nowhere to go without a database, so the writes -- and the metrics that only exist to feed them -- are now skipped, and the fact is stated once at startup.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nickhuo
changed the title
|
This doesn't look like the OTLP exporter branch? The telemetry writes you are skipping won't be used in the future |
|
I just tagged Felipe somewhere about this but I can't find it lol, but if UI doesn't pull from that DB anymore you can just remove the code instead of adding a skip file from the telemetry_logger.py |
|
The agent metrics doesn't currently have a OTLP reciever though so just remove the runtime_information table logic |
What is SQLAlchemy used for here? The purpose of this PR is to keep the log from polling every five seconds and flooding other error msg |
2 participants
If we assume the database URL is a prerequisite, we can ignore this pr. @Saaketh0 @iidsample
With no database configured, every metrics poll tried to build a SQLAlchemy engine from the string
"None". It failed the same way every 5 seconds — Could not parse SQLAlchemy URL from given URL string— burying the errors operators actually need to see.Skip telemetry when there’s no database and fix URL resolution